From owner-freebsd-python@freebsd.org Tue Jun 5 17:36:57 2018
Return-Path: <owner-freebsd-python@freebsd.org>
Delivered-To: freebsd-python@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
by mailman.ysv.freebsd.org (Postfix) with ESMTP id 60779FE7174
for <freebsd-python@mailman.ysv.freebsd.org>;
Tue, 5 Jun 2018 17:36:57 +0000 (UTC)
(envelope-from bugzilla-noreply@freebsd.org)
Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org
[IPv6:2001:1900:2254:206a::50:5])
by mx1.freebsd.org (Postfix) with ESMTP id F07358695C
for <freebsd-python@freebsd.org>; Tue, 5 Jun 2018 17:36:56 +0000 (UTC)
(envelope-from bugzilla-noreply@freebsd.org)
Received: by mailman.ysv.freebsd.org (Postfix)
id AD643FE7163; Tue, 5 Jun 2018 17:36:56 +0000 (UTC)
Delivered-To: python@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
by mailman.ysv.freebsd.org (Postfix) with ESMTP id 89630FE7162
for <python@mailman.ysv.freebsd.org>; Tue, 5 Jun 2018 17:36:56 +0000 (UTC)
(envelope-from bugzilla-noreply@freebsd.org)
Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org
[IPv6:2001:1900:2254:206a::19:3])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mxrelay.ysv.freebsd.org",
Issuer "Let's Encrypt Authority X3" (verified OK))
by mx1.freebsd.org (Postfix) with ESMTPS id 0B58F86958
for <python@FreeBSD.org>; Tue, 5 Jun 2018 17:36:56 +0000 (UTC)
(envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
[IPv6:2001:1900:2254:206a::16:76])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client did not present a certificate)
by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 50D321C2E8
for <python@FreeBSD.org>; Tue, 5 Jun 2018 17:36:55 +0000 (UTC)
(envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org ([127.0.1.118])
by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w55Hatsp082011
for <python@FreeBSD.org>; Tue, 5 Jun 2018 17:36:55 GMT
(envelope-from bugzilla-noreply@freebsd.org)
Received: (from www@localhost)
by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w55HatBr082007
for python@FreeBSD.org; Tue, 5 Jun 2018 17:36:55 GMT
(envelope-from bugzilla-noreply@freebsd.org)
X-Authentication-Warning: kenobi.freebsd.org: www set sender to
bugzilla-noreply@freebsd.org using -f
From: bugzilla-noreply@freebsd.org
To: python@FreeBSD.org
Subject: [Bug 228769] devel/py-testtools: Add missing dependencies (with
workaround for devel/py-fixtures et al.)
Date: Tue, 05 Jun 2018 17:36:54 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords:
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: freebsd_ports@k-worx.org
X-Bugzilla-Status: New
X-Bugzilla-Resolution:
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: sunpoet@FreeBSD.org
X-Bugzilla-Flags: maintainer-feedback?
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
op_sys bug_status bug_severity priority component assigned_to reporter cc
flagtypes.name attachments.created
Message-ID: <bug-228769-21822@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-python@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: FreeBSD-specific Python issues <freebsd-python.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-python>,
<mailto:freebsd-python-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-python/>
List-Post: <mailto:freebsd-python@freebsd.org>
List-Help: <mailto:freebsd-python-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-python>,
<mailto:freebsd-python-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jun 2018 17:36:57 -0000
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D228769
Bug ID: 228769
Summary: devel/py-testtools: Add missing dependencies (with
workaround for devel/py-fixtures et al.)
Product: Ports & Packages
Version: Latest
Hardware: Any
OS: Any
Status: New
Severity: Affects Only Me
Priority: ---
Component: Individual Port(s)
Assignee: sunpoet@FreeBSD.org
Reporter: freebsd_ports@k-worx.org
CC: python@FreeBSD.org, sunpoet@FreeBSD.org
Flags: maintainer-feedback?(sunpoet@FreeBSD.org)
Assignee: sunpoet@FreeBSD.org
Attachment #194031 maintainer-approval?(sunpoet@FreeBSD.org)
Flags:
CC: sunpoet@FreeBSD.org
Created attachment 194031
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D194031&action=
=3Dedit
py-testtools_RUN_DEPENDS.patch
Hello,
attached is a patch, that does following modifications:
for port devel/py-testtools:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
- adds missing dependencies to RUN_DEPENDS (devel/py-pbr, devel/py-fixtures,
devel/py-mimeparse, devel/py-unittest2, devel/py-six)
- adds LICENSE_FILE
- bumps PORTREVISION
- changes occurrences of FLAVOR to PY_FLAVOR
for port devel/py-fixtures:
~~~~~~~~~~~~~~~~~~~~~~~~~~~
- removes devel/py-testtools from RUN_DEPENDS to avoid circular dependencies
(devel/py-testtools + devel/py-fixtures depends on each other, please see
further down below for an explanation)
- adds a comment for the workaround
- changes occurrences of FLAVOR to PY_FLAVOR
- bumps PORTREVISION
for port devel/py-python-subunit:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
- removes redundant entries from RUN_DEPENDS
- bumps PORTREVISION
- Note: my approval as maintainer for the change is given
for port devel/py-mox3:
~~~~~~~~~~~~~~~~~~~~~~~
- changes devel/py-fixtures to devel/py-testtools in RUN_DEPENDS
- Note: my approval as maintainer for the change is given
Explanation for the workaround:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
As already stated above the ports devel/py-testtools and devel/py-fixtures
depends on each other. If those dependencies would be set in the Makefiles =
of
both ports it would introduce a circular depency which
There might be two workarounds to cope with the problem (the attached patch
uses option b):
a) Create a test for both ports that check if the port sees itself in the
RUN_DEPENDS and remove the entry in that case. But there's no known use-cas=
e in
the ports tree and this approach might be prone to errors.
b) Break the possibility of a circular dependency by pruning the dependenci=
es
on one of the both ports. I did choose devel/py-fixtures because that port =
is
listed as single instance in only one port at the moment (=3D devel/py-mox3=
).
The workaround would be now:
- If in the future one port requires devel/py-fixtures without listing
devel/py-testtools explicitly then the first one should be replaced with the
latter one to resolve the given dependencies (included for devel/py-mox3 in=
the
supplied patch).
What do you think about it?
QA:
~~~
- poudriere (11.1-RELEASE amd64 + i386) for each py27 + py36 flavor -> OK
- portlint -> OK
--=20
You are receiving this mail because:
You are on the CC list for the bug.=