Date: Wed, 16 Dec 2020 21:43:53 -0600 From: Kyle Evans <kevans@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r368713 - head/usr.sbin/freebsd-update Message-ID: <CACNAnaGG-wEjGd6z%2ByY92b0cHRm_=Gzvoj0Y2hPbheUK2=7uSw@mail.gmail.com> In-Reply-To: <202012170342.0BH3gs5B070847@repo.freebsd.org> References: <202012170342.0BH3gs5B070847@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Dec 16, 2020 at 9:43 PM Kyle Evans <kevans@freebsd.org> wrote: > > Author: kevans > Date: Thu Dec 17 03:42:54 2020 > New Revision: 368713 > URL: https://svnweb.freebsd.org/changeset/base/368713 > > Log: > freebsd-update: unconditionally regenerate passwd/login.conf files > > The existing logic is nice in theory, but in practice freebsd-update will > not preserve the timestamps on these files. When doing a major upgrade, e.g. > from 12.1-RELEASE -> 12.2-RELEASE, pwd.mkdb et al. appear in the INDEX and > we clobber the timestamp several times in the process of packaging up the > existing system into /var/db/freebsd-update/files and extracting for > comparisons. This leads to these files not getting regenerated when they're > most likely to be needed. > > Measures could be taken to preserve timestamps, but it's unclear whether > the complexity and overhead of doing so is really outweighed by the marginal > benefit. > > I observed this issue when pkg subsequently failed to install a package that > wanted to add a user, claiming that the user was removed in the process. > bapt@ pointed to this pre-existing bug with freebsd-update as the cause. > > PR: 234014, 232921 > Reviewed by: bapt, emaste > MFC after: 1 week > Differential Revision: https://reviews.freebsd.org/D27635 > Bah, I found this one immediately after: PR: 235766
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaGG-wEjGd6z%2ByY92b0cHRm_=Gzvoj0Y2hPbheUK2=7uSw>