From owner-freebsd-testing@freebsd.org Sun Oct 18 01:56:05 2015 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB894A10973 for ; Sun, 18 Oct 2015 01:56:05 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x22e.google.com (mail-pa0-x22e.google.com [IPv6:2607:f8b0:400e:c03::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9C0B9620; Sun, 18 Oct 2015 01:56:05 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by pabrc13 with SMTP id rc13so155426159pab.0; Sat, 17 Oct 2015 18:56:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=hvEj2wrxTqMhXN696sRV6rltroGtrykSH3gaqc03zvs=; b=QnHynB7YgfOVLrLzZ8DOi4f5Fzxv+RZwKHfXwOU1VF+VdHPycaJ0pcSUdz/CS02AgV tGWc+/ga7ZVe4ZfXcw1QLq7iFRNVPjlOT6Sz4mGAKs3iNfOIu8iI4I/1cMMzt8aZSqnZ o87zvIa+qR+tSWRjVNIiBmfCQtWqz2L4QTop71VAPYzEnruC1Sqj3rx+2LBMkUNHmqKU S0/g5I0ofF0xNOJKn1KOcWuyP+TA19QKkMAkRflPaaw6En/LgrP6wfod1/OmcNcUY2MZ gPiq3y1nnqhHKgo0+4RgErzmv8aoXwpnE0eyi8mIjnAYrtdD+GFJJC8ySxBegYkHGDSU Z4hQ== X-Received: by 10.67.15.100 with SMTP id fn4mr26475115pad.120.1445133365174; Sat, 17 Oct 2015 18:56:05 -0700 (PDT) Received: from ?IPv6:2601:601:800:126d:61c1:5eeb:a155:3bc5? ([2601:601:800:126d:61c1:5eeb:a155:3bc5]) by smtp.gmail.com with ESMTPSA id ro3sm5827917pbc.69.2015.10.17.18.56.04 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 17 Oct 2015 18:56:04 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: [RFC] Rename `make test` in suite.test.mk with `make regress` From: NGie Cooper In-Reply-To: <5C39F495-5717-450F-8460-14B69DD48AD6@freebsd.org> Date: Sat, 17 Oct 2015 18:56:04 -0700 Cc: "freebsd-testing@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <5C39F495-5717-450F-8460-14B69DD48AD6@freebsd.org> To: Julio Merino X-Mailer: Apple Mail (2.2104) X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Oct 2015 01:56:06 -0000 > On Oct 17, 2015, at 18:50, Julio Merino wrote: >=20 > On Oct 17, 2015, at 18:03, NGie Cooper wrote: >>=20 >> Hi all, >> There=E2=80=99s a lesser known target in suite.test.mk that runs = `kyua test` in a similar manner to how Jenkins and other groups have = integrated kyua into their test infrastructures. >> The legacy target on FreeBSD was `regress`, but the target = created with the bsd.test.mk creation back a few years ago was `test`. = Why change from `test` to `regress`? There are places in the tree = (bin/test for example) that have targets named test, so in order to = avoid clashing with a common target (name), it=E2=80=99s best to use the = legacy target name. >> Would anyone have any serious heartburn over the change? >=20 > Is this only because of bin/test? Seems like renaming a target to = avoid that one collision is just moving the problem around. It is = possible that some other directory could later grow a target that = conflicts with your new name. Yes, I realize that. The goal though is I want to be able to call `make = ` from the top and it would iterate down each and every = subdirectory and run tests. Sadly, most people don=E2=80=99t care to figure out how kyua works = enough to run `kyua test`=E2=80=A6 so I=E2=80=99m just trying to lower = the barrier of entry in a way that will work 100% of the time. > Strictly speaking, "regress" is wrong. We do not have regression = tests only. Also, "regress" is a pretty obscure name for a target; it = does not appear in any other projects nor in any other build systems = that I know of. Unfortunately it=E2=80=99s been in place a lot longer than anything = else, so it=E2=80=99s kind of the =E2=80=9Cdefacto standard=E2=80=9D. = That said... > Have you considered "check"? That'd be in line with what automake = does, for example, which would homogenize the target name with a ton of = other projects out there. =E2=80=A6 `make check` would be ok too. I just have to comb the tree for = binaries that don=E2=80=99t match `check`. Thanks! -NGie=