From owner-freebsd-current@freebsd.org Tue Oct 13 01:28:08 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BE28B3B63 for ; Tue, 13 Oct 2015 01:28:08 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-ig0-x22d.google.com (mail-ig0-x22d.google.com [IPv6:2607:f8b0:4001:c05::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 860FD1433; Tue, 13 Oct 2015 01:28:08 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by igbkq10 with SMTP id kq10so83600979igb.0; Mon, 12 Oct 2015 18:28:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:cc:message-id:from:to:in-reply-to:content-type :content-transfer-encoding:mime-version:subject:date:references; bh=SSh9EtDqVeI2A5cqx22xOGPCWpE64yQCvCJVp91h6PE=; b=zoBwwhSHEp4flj2BqO7S6f8XTlQqE9ZMMCR8VZYYUOCmeT/nWThFhs+vNWyGH9N0Ae kGQY1un5jRoan8XIxG/J74B4Aw3zy61udAUiu2Q0bdYQVbmWMDGrgAhXj4EtX02UrY8c 9jjlLUKTTtdzC1eD3wHUDt29GsTxzRubbBfpQ15JZChqUcSkrHbdYUdY4RZb3qtI4O0o R3gcgnYhm8D12VCJ+/HLycjeElzlEtrQXCfGQr+TeytUBhMF9bPvdI8hD7Uq9yNhKH+h fEJ095boujS+Ysb0DrdxHzQYbOh1FftZSZ0GW8HIJoVsPPUXzVzVw0ZqMW/AYXTaBi/9 Whaw== X-Received: by 10.50.114.166 with SMTP id jh6mr16325782igb.47.1444699688021; Mon, 12 Oct 2015 18:28:08 -0700 (PDT) Received: from blackstar.knownspace (c-98-240-160-157.hsd1.mn.comcast.net. [98.240.160.157]) by smtp.gmail.com with ESMTPSA id b10sm510347igb.9.2015.10.12.18.28.07 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 12 Oct 2015 18:28:07 -0700 (PDT) Sender: Justin Hibbits Cc: FreeBSD Current , gerald@FreeBSD.org, mi@aldan.algebra.com Message-Id: From: Justin Hibbits To: Pedro Giffuni In-Reply-To: <561C4F10.7060206@FreeBSD.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: r288669 breaks ports building with USE_GCC=yes Date: Mon, 12 Oct 2015 20:28:34 -0500 References: <561C1523.7080200@FreeBSD.org> <561C17F2.2030206@FreeBSD.org> <561C4F10.7060206@FreeBSD.org> X-Mailer: Apple Mail (2.936) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Oct 2015 01:28:08 -0000 Hi Pedro, On Oct 12, 2015, at 7:23 PM, Pedro Giffuni wrote: > > > On 10/12/2015 3:33 PM, Justin Hibbits wrote: >> Hi Pedro, >> >> On Mon, Oct 12, 2015 at 3:28 PM, Pedro Giffuni >> wrote: >>> Hi again; >>> >>> On 12/10/2015 03:16 p.m., Pedro Giffuni wrote: >>>> Hello; >>>> >>>> On 12/10/2015 02:56 p.m., Justin Hibbits wrote: >>>>> The default ports gcc for USE_GCC is still 4.8, which does not >>>>> support >>>>> -fstack-protector-strong. This breaks several ports including >>>>> (from >>>>> my poudriere run): libfpx and qt4-sqlite3-plugin. >>>>> >>>>> - Justin >>>> >>>> r288669 only applies to base. It was tested with an exp-run and >>>> there were >>>> no >>>> failures so this is something wrong in your setup. >>>> >>> Ugh ... now that I remember, we actually used -stack-protector-all >>> for the >>> exp-run >>> (which is supported in pretty much every gcc). >>> >>> Still, the change should only apply to the base system and not >>> ports, and >>> -stack-protector-strong appears to have been backported to gcc48 >>> last year (see PR 186852). >>> >>> cheers, >>> >>> Pedro. >>> >> All I can say is building with USE_GCC=yes, I see the following >> error: >> >> g++48: error: unrecognized command line option '-fstack-protector- >> strong' >> >> This is using the latest gcc48 in ports (full tree updated >> yesterday). > > OK, I tested graphics/libfpx on i386-current: > > -stack-protector-strong indeed gets pulled in due to some non-orthodox > workarounds in files/Makefile.bsd. > > g++48 accepts it just fine and the port compiles. > > Is this a platform that has GCC issues, perhaps? It looks like one > of those > "unfortunately series of events" that may have to be fixed in the port > and/or gcc48. > > Pedro. > This is on powerpc64. I see the patch has been there for 16 months, but for some reason, the /usr/local/bin/gcc48 doesn't contain the patch. I ran `strings` on the binary, and it has the following string: %{fstack-protector|fstack-protector-all:-lssp_nonshared} Which, if you examine files/patch-stackprotector-gcc, is the unpatched string. I have no idea why this is the case. - Justin