From owner-cvs-all Tue Oct 16 5:55:42 2001 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 75DB637B407; Tue, 16 Oct 2001 05:55:38 -0700 (PDT) Received: (from bde@localhost) by freefall.freebsd.org (8.11.4/8.11.4) id f9GCtcv33034; Tue, 16 Oct 2001 05:55:38 -0700 (PDT) (envelope-from bde) Message-Id: <200110161255.f9GCtcv33034@freefall.freebsd.org> From: Bruce Evans Date: Tue, 16 Oct 2001 05:55:38 -0700 (PDT) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/i386/isa npx.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG bde 2001/10/16 05:55:38 PDT Modified files: sys/i386/isa npx.c Log: Commit my old fixes for cosmetic bugs in npxprobe() so that they aren't lost when the buggy code goes away completely: - don't assume that the npx irq number is >= 8. Rev.1.73 only reversed part of the hard-coding of it to 13 in rev.1.66. - backed out the part of rev.1.84 that added a highly confused comment about an enable_intr() being "highly bogus". The whole reason for existence of npxprobe() (separate from the main probe, npxprobe1()) is to handle the complications to make this enable_intr() safe. - backed out the part of rev.1.94 that modified npxprobe(). It mainly broke the enable_intr() to restore_intr(). Restoring the interrupt state in a nested way is precisely what is not wanted here. It was harmless in practice because npxprobe() is called with interrupts enabled, so restoring the interrupt state enables interrupts. Most of npxprobe() is a no-op for the same reason... Revision Changes Path 1.115 +8 -13 src/sys/i386/isa/npx.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message