From owner-cvs-gnu Mon May 22 16:30:19 1995 Return-Path: cvs-gnu-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id QAA00986 for cvs-gnu-outgoing; Mon, 22 May 1995 16:30:19 -0700 Received: from veda.is (root@veda.is [193.4.230.1]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id MAA02962 ; Mon, 22 May 1995 12:24:58 -0700 Received: (from adam@localhost) by veda.is (8.6.11/8.6.9) id TAA09678; Mon, 22 May 1995 19:24:31 GMT From: Adam David Message-Id: <199505221924.TAA09678@veda.is> Subject: Re: cvs commit: src/gnu/lib/libreadline display.c To: rgrimes@gndrsh.aac.dev.com (Rodney W. Grimes) Date: Mon, 22 May 1995 19:24:30 +0000 () Cc: adam@freefall.cdrom.com, CVS-commiters@freefall.cdrom.com, cvs-gnu@freefall.cdrom.com In-Reply-To: <199505221747.KAA05201@gndrsh.aac.dev.com> from "Rodney W. Grimes" at May 22, 95 10:47:01 am X-Mailer: ELM [version 2.4 PL23] MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Content-Length: 695 Sender: cvs-gnu-owner@freebsd.org Precedence: bulk > > Modified: gnu/lib/libreadline display.c > > Log: > > eliminate coredump for readline(NULL) case > > Did I miss a message about code freeze being lifted??? Bugfix only, as explicitly permitted by freefall's motd. > A library is defanitly a critical place to be patching. There is no change of interface, only an advertised functionality that dumped core instead of the expected behaviour. > Reviewd by: ?????? Is this necessary for a trivial bugfix? old: strlen(local_prompt) new: local_prompt ? strlen(local_prompt) : 0 local_prompt == NULL is a valid state, as empty prompts may be represented as either "" or NULL in the rest of the code. -- Adam David