From owner-svn-ports-head@FreeBSD.ORG  Mon Jun 24 12:03:16 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 5A962C69; Mon, 24 Jun 2013 12:03:16 +0000 (UTC)
Date: Mon, 24 Jun 2013 12:03:16 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Ryan Steinmetz <zi@FreeBSD.org>
Subject: Re: svn commit: r321677 - in head/security/duo: . files
Message-ID: <20130624120316.GB79369@FreeBSD.org>
References: <201306241155.r5OBtgQj057667@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201306241155.r5OBtgQj057667@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Jun 2013 12:03:16 -0000

On Mon, Jun 24, 2013 at 11:55:42AM +0000, Ryan Steinmetz wrote:
> New Revision: 321677
> URL: http://svnweb.freebsd.org/changeset/ports/321677
> 
> +.if ${OSVERSION} >= 1000000
> +USE_GCC=	yes
> +.endif

Presuming it's due to Clang...

Two quick questions: 1) why not just say USE_GCC=any; and 2) how hard would
it be to fix Clang fallouts, and remove any explicit compiler requirement?

Note that =yes implies GCC 4.6+ or something, yet on OSVERSION < 1000000
apparently our default system 4.2 is enough.

>  	@${CAT} ${PKGMESSAGE}

It would be nice if cat(1) had been surrounded with ${ECHO_MSG}'s to ensure
consistent padding when installing from package vs. ports.  If any padding
is present in the pkg-message file itself, it should be removed.

./danfe