Date: Mon, 24 Jun 2013 12:03:16 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Ryan Steinmetz <zi@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r321677 - in head/security/duo: . files Message-ID: <20130624120316.GB79369@FreeBSD.org> In-Reply-To: <201306241155.r5OBtgQj057667@svn.freebsd.org> References: <201306241155.r5OBtgQj057667@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 24, 2013 at 11:55:42AM +0000, Ryan Steinmetz wrote: > New Revision: 321677 > URL: http://svnweb.freebsd.org/changeset/ports/321677 > > +.if ${OSVERSION} >= 1000000 > +USE_GCC= yes > +.endif Presuming it's due to Clang... Two quick questions: 1) why not just say USE_GCC=any; and 2) how hard would it be to fix Clang fallouts, and remove any explicit compiler requirement? Note that =yes implies GCC 4.6+ or something, yet on OSVERSION < 1000000 apparently our default system 4.2 is enough. > @${CAT} ${PKGMESSAGE} It would be nice if cat(1) had been surrounded with ${ECHO_MSG}'s to ensure consistent padding when installing from package vs. ports. If any padding is present in the pkg-message file itself, it should be removed. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130624120316.GB79369>