From owner-svn-src-head@FreeBSD.ORG  Thu Jul 19 20:21:44 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2FB36106564A;
	Thu, 19 Jul 2012 20:21:44 +0000 (UTC)
	(envelope-from pawel@dawidek.net)
Received: from mail.dawidek.net (garage.dawidek.net [91.121.88.72])
	by mx1.freebsd.org (Postfix) with ESMTP id E3FF58FC15;
	Thu, 19 Jul 2012 20:21:43 +0000 (UTC)
Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149])
	by mail.dawidek.net (Postfix) with ESMTPSA id 902134AA;
	Thu, 19 Jul 2012 22:21:33 +0200 (CEST)
Date: Thu, 19 Jul 2012 22:19:20 +0200
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: Konstantin Belousov <kib@FreeBSD.org>
Message-ID: <20120719201920.GF1401@garage.freebsd.pl>
References: <201207191022.q6JAMtbw068159@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="udcq9yAoWb9A4FsZ"
Content-Disposition: inline
In-Reply-To: <201207191022.q6JAMtbw068159@svn.freebsd.org>
X-OS: FreeBSD 10.0-CURRENT amd64
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r238614 - in head/sys: kern sys
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jul 2012 20:21:44 -0000


--udcq9yAoWb9A4FsZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 19, 2012 at 10:22:55AM +0000, Konstantin Belousov wrote:
> Author: kib
> Date: Thu Jul 19 10:22:54 2012
> New Revision: 238614
> URL: http://svn.freebsd.org/changeset/base/238614
>=20
> Log:
>   Implement F_DUPFD_CLOEXEC command for fcntl(2), specified by SUSv4.
>  =20
>   PR:	  standards/169962
>   Submitted by:	Jukka A. Ukkonen <jau iki fi>
>   MFC after:	1 week
[...]
> +	if ((flags & DUP_CLOEXEC) !=3D 0)
> +		fdp->fd_ofileflags[new] =3D fdp->fd_ofileflags[old] | UF_EXCLOSE;
> +	else
> +		fdp->fd_ofileflags[new] =3D fdp->fd_ofileflags[old] & ~UF_EXCLOSE;
>  	fdp->fd_ofileflags[new] =3D fdp->fd_ofileflags[old] &~ UF_EXCLOSE;

It seems that you forgot to remove the line above, which results in
always removing the UF_EXCLOSE flag.

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl

--udcq9yAoWb9A4FsZ
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlAIa8cACgkQForvXbEpPzQT+ACff5pFhQ1rCede2YIgNlVFIy+j
VTQAoLDRG4Esp9To5eohNFX0bdzNOC1X
=RSPm
-----END PGP SIGNATURE-----

--udcq9yAoWb9A4FsZ--