From owner-cvs-all Fri Jul 23 10:10: 2 1999 Delivered-To: cvs-all@freebsd.org Received: from caspian.plutotech.com (caspian.plutotech.com [206.168.67.80]) by hub.freebsd.org (Postfix) with ESMTP id 33FAE14C3F; Fri, 23 Jul 1999 10:09:57 -0700 (PDT) (envelope-from gibbs@caspian.plutotech.com) Received: from caspian.plutotech.com (localhost [127.0.0.1]) by caspian.plutotech.com (8.9.3/8.9.1) with ESMTP id LAA12707; Fri, 23 Jul 1999 11:08:28 -0600 (MDT) (envelope-from gibbs@caspian.plutotech.com) Message-Id: <199907231708.LAA12707@caspian.plutotech.com> X-Mailer: exmh version 2.0.2 2/24/98 To: Brian Feldman Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/inetd builtins.c In-reply-to: Your message of "Fri, 23 Jul 1999 08:49:14 PDT." <199907231549.IAA71557@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 23 Jul 1999 11:08:28 -0600 From: "Justin T. Gibbs" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk >green 1999/07/23 08:49:14 PDT > > Modified files: > usr.sbin/inetd builtins.c > Log: > Ahem. Put things back a bit. I declare variables in the scope they're > used! I don't declare every variable at the top of a function because > that wastes stack space. I've clarified the error a bit (for if asprintf() > filas.) The stack space usage is usually the same (depends on the compiler), but semantically limiting the scope of the variable to just the area where it is used is, IMO, advantageous from a maintenance standpoint. -- Justin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message