From owner-svn-src-head@freebsd.org Thu Oct 31 12:51:28 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 62DA81A77C7; Thu, 31 Oct 2019 12:51:28 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 473lZ64Cx9z4FNB; Thu, 31 Oct 2019 12:51:25 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id 2c6e3ef1; Thu, 31 Oct 2019 13:51:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=lsRg2lpCu3RW3SYh6Ql1RghmbZY=; b=fSkH85xe6tRpgq6XUxAWa+SyPKZv l1UDL0s3AiCxlFRWvvcE7XJ8kvW+iVmOMwxrGZ+NkjkuqTXGSdIw+i/hq+yoZ7p8 VhfRQL2u4bQip5h4+ZDLsE6rv6LvqSQgZu8OVCnia5NWuh4YD+ZeFj1w4hF47xdU ZmSW9+EvajU7RGE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=p0nJwtUB5zeq9qYPXzSwLyH5Alz07iDwI5C+mbZfQLoP1LxoV0Zp5/xx 2KIS2j2mymKir+ouJWYWlwf7IqauCus0FHlzYm776jsB36GChIpHfXP5zrpsBPDn X2as2MXk183dBEXIHiB1jD/85AXC69xW9eYRa5+kRpnzqsDKSic= Received: from sonic.home.blih.net (ip-9.net-89-3-105.rev.numericable.fr [89.3.105.9]) by mail.blih.net (OpenSMTPD) with ESMTPSA id 0ece2121 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Thu, 31 Oct 2019 13:51:18 +0100 (CET) Date: Thu, 31 Oct 2019 13:51:18 +0100 From: Emmanuel Vadot To: Ilya Bakulin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r354206 - head/sys/arm/allwinner Message-Id: <20191031135118.4e9222bb05879d1602bf3161@bidouilliste.com> In-Reply-To: <201910302043.x9UKhRth083957@repo.freebsd.org> References: <201910302043.x9UKhRth083957@repo.freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 473lZ64Cx9z4FNB X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mail header.b=fSkH85xe; dmarc=none; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.177.182 as permitted sender) smtp.mailfrom=manu@bidouilliste.com X-Spamd-Result: default: False [-0.86 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mail]; NEURAL_HAM_MEDIUM(-0.37)[-0.374,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:212.83.177.182/32]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; MV_CASE(0.50)[]; DMARC_NA(0.00)[bidouilliste.com]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-0.97)[-0.967,0]; DKIM_TRACE(0.00)[bidouilliste.com:+]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; IP_SCORE(0.39)[ip: (-0.61), ipnet: 212.83.160.0/19(2.44), asn: 12876(0.10), country: FR(-0.00)]; ASN(0.00)[asn:12876, ipnet:212.83.160.0/19, country:FR]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Oct 2019 12:51:28 -0000 On Wed, 30 Oct 2019 20:43:27 +0000 (UTC) Ilya Bakulin wrote: > Author: kibab > Date: Wed Oct 30 20:43:27 2019 > New Revision: 354206 > URL: https://svnweb.freebsd.org/changeset/base/354206 > > Log: > Use the new cam_sim_alloc_dev function to properly initialize SIM > > Using cam_sim_alloc_dev() allows to properly set sim_dev field so that > sdiob(4) can attach to the CAM device that represents SDIO card. > The same change for SDHCI driver happened in r348800. > > Approved by: imp (mentor) > Differential Revision: https://reviews.freebsd.org/D22192 > > Modified: > head/sys/arm/allwinner/aw_mmc.c > > Modified: head/sys/arm/allwinner/aw_mmc.c > ============================================================================== > --- head/sys/arm/allwinner/aw_mmc.c Wed Oct 30 20:08:10 2019 (r354205) > +++ head/sys/arm/allwinner/aw_mmc.c Wed Oct 30 20:43:27 2019 (r354206) > @@ -526,8 +526,8 @@ aw_mmc_attach(device_t dev) > } > > mtx_init(&sc->sim_mtx, "awmmcsim", NULL, MTX_DEF); > - sc->sim = cam_sim_alloc(aw_mmc_cam_action, aw_mmc_cam_poll, > - "aw_mmc_sim", sc, device_get_unit(dev), > + sc->sim = cam_sim_alloc_dev(aw_mmc_cam_action, aw_mmc_cam_poll, > + "aw_mmc_sim", sc, dev, > &sc->sim_mtx, 1, 1, sc->devq); > > if (sc->sim == NULL) { > @@ -1514,6 +1514,7 @@ static device_method_t aw_mmc_methods[] = { > /* Bus interface */ > DEVMETHOD(bus_read_ivar, aw_mmc_read_ivar), > DEVMETHOD(bus_write_ivar, aw_mmc_write_ivar), > + DEVMETHOD(bus_add_child, bus_generic_add_child), Why is this change needed ? > > /* MMC bridge interface */ > DEVMETHOD(mmcbr_update_ios, aw_mmc_update_ios), -- Emmanuel Vadot