From owner-svn-src-head@freebsd.org Mon Nov 21 20:17:43 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 44DFCC4D645; Mon, 21 Nov 2016 20:17:43 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 222758B0; Mon, 21 Nov 2016 20:17:42 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id C31C710AA1D; Mon, 21 Nov 2016 15:17:34 -0500 (EST) From: John Baldwin To: Warner Losh Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r308869 - head/sbin/nvmecontrol Date: Mon, 21 Nov 2016 12:16:35 -0800 Message-ID: <2066039.9u44RCLHQT@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-PRERELEASE; KDE/4.14.10; amd64; ; ) In-Reply-To: References: <201611192146.uAJLkDP5094317@repo.freebsd.org> <123365400.XYmKG93e4H@ralph.baldwin.cx> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Mon, 21 Nov 2016 15:17:34 -0500 (EST) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Nov 2016 20:17:43 -0000 On Monday, November 21, 2016 12:50:35 PM Warner Losh wrote: > On Mon, Nov 21, 2016 at 11:07 AM, John Baldwin wrote: > > On Saturday, November 19, 2016 09:46:13 PM Warner Losh wrote: > >> Author: imp > >> Date: Sat Nov 19 21:46:13 2016 > >> New Revision: 308869 > >> URL: https://svnweb.freebsd.org/changeset/base/308869 > >> > >> Log: > >> i386 turns out to not have __uint128_t. So confusingly use 64-bit math > >> instead. Since we're little endian, we can get away with it. Also, > >> since the counters in quesitons would require billions of iops for > >> tens of billions of seconds to overflow, and since such data rates are > >> unlikely for people using i386 for a while, that's OK. The fastest > >> cards today can't do even a million IOPs. > >> > >> Noticed by: dim@ > >> Sponsored by: Netflix, Inc > > > > It probably has it if you compile with -march= where is new > > enough to have SSE. > > Yea, but this solution was good enough... There's also a lot of issues > with 128bit ints in different versions of gcc and I didn't want to > play the whack-a-mole game, so I punted. Yes. We don't require SSE for i386, so we're stuck handling the non-SSE case currently. > > Is nvme inherently x86-only? > > No. However, the implementation was done by Intel, only tested on x86 > and has known issues with endian-ness. So we build only on x86. Something of a shame as you can probably shove one of these boards in arm64 servers. -- John Baldwin