Date: Sun, 30 Aug 2020 17:13:04 +0000 (UTC) From: Gleb Smirnoff <glebius@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r364975 - head/sys/dev/mn Message-ID: <202008301713.07UHD4Cv081029@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: glebius Date: Sun Aug 30 17:13:04 2020 New Revision: 364975 URL: https://svnweb.freebsd.org/changeset/base/364975 Log: Followup on r364922. Old comment said that the only reason to put the hook at queue mode was that mn_rx_intr() doesn't run at splnet level. In today's netgraph the only legitimate reason for queue mode is recursion avoidance. So I see no reason for queue mode here. Not tested! Modified: head/sys/dev/mn/if_mn.c Modified: head/sys/dev/mn/if_mn.c ============================================================================== --- head/sys/dev/mn/if_mn.c Sun Aug 30 16:27:58 2020 (r364974) +++ head/sys/dev/mn/if_mn.c Sun Aug 30 17:13:04 2020 (r364975) @@ -743,8 +743,6 @@ ngmn_connect(hook_p hook) if (!(u & 1)) printf("%s: init chan %d stat %08x\n", sc->name, chan, u); sc->m32x->stat = 1; - /* force outward queueing */ - NG_HOOK_FORCE_QUEUE(NG_HOOK_PEER(hook)); return (0); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202008301713.07UHD4Cv081029>