From owner-cvs-src@FreeBSD.ORG  Fri Jan 11 02:39:25 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 402E116A417;
	Fri, 11 Jan 2008 02:39:25 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id 385A813C43E;
	Fri, 11 Jan 2008 02:39:25 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 2B1A21A4D7E; Thu, 10 Jan 2008 18:36:28 -0800 (PST)
Date: Thu, 10 Jan 2008 18:36:28 -0800
From: Alfred Perlstein <alfred@freebsd.org>
To: Peter Wemm <peter@wemm.org>
Message-ID: <20080111023628.GB99258@elvis.mu.org>
References: <200801102336.m0ANa0mP035046@repoman.freebsd.org>
	<20080111010033.GC52842@elvis.mu.org>
	<e7db6d980801101741j3c0a23aeh25e83b091394e011@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e7db6d980801101741j3c0a23aeh25e83b091394e011@mail.gmail.com>
User-Agent: Mutt/1.4.2.3i
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org,
	John Baldwin <jhb@freebsd.org>
Subject: Re: cvs commit: src/sys/nfsclient nfs_socket.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jan 2008 02:39:25 -0000

* Peter Wemm <peter@wemm.org> [080110 17:39] wrote:
> On Jan 10, 2008 5:00 PM, Alfred Perlstein <alfred@freebsd.org> wrote:
> >
> > * John Baldwin <jhb@FreeBSD.org> [080110 15:33] wrote:
> > > jhb         2008-01-10 23:36:00 UTC
> > >
> > >   FreeBSD src repository
> > >
> > >   Modified files:
> > >     sys/nfsclient        nfs_socket.c
> > >   Log:
> > >   Pass curthread to various socket routines (socreate(), sobind(), and
> > >   soconnect()) instead of &thread0 when establishing a connection to the NFS
> > >   server.  Otherwise inconsistent credentials may be used when setting up
> > >   the NFS socket.
> >
> > I'm not sure, but I think this may be a regression, I seem to recall
> > that a long time ago it was switched to &thread0 because otherwise
> > certain operations can fail due to curthread not running as root.
> 
> That's my recollection too.  For example, when nfs is configured to
> bind to a priviliged local port for making queries or connections, it
> had to be done as root.  With tcp mounts, the connection can be
> dropped and a reconnect required at any time.

This could be implemented by a handoff to a thread that does the
appropriate setuid call beforehand, or perhaps the credential
inconsistencies can be further expained or fixed.

-Alfred