From owner-cvs-all Mon May 27 17:58:38 2002 Delivered-To: cvs-all@freebsd.org Received: from rover.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id BF29F37B400; Mon, 27 May 2002 17:58:27 -0700 (PDT) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.3/8.11.3) with ESMTP id g4S0wQY20716; Mon, 27 May 2002 18:58:27 -0600 (MDT) (envelope-from imp@village.org) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.11.6/8.11.6) with ESMTP id g4S0wLG24766; Mon, 27 May 2002 18:58:25 -0600 (MDT) (envelope-from imp@village.org) Date: Mon, 27 May 2002 18:58:11 -0600 (MDT) Message-Id: <20020527.185811.128396494.imp@village.org> To: brooks@one-eyed-alien.net Cc: cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/i386/pci pci_cfgreg.c From: "M. Warner Losh" In-Reply-To: <20020527150933.A18324@Odin.AC.HMC.Edu> References: <200204241530.g3OFUCL52082@freefall.freebsd.org> <20020527150933.A18324@Odin.AC.HMC.Edu> X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: <20020527150933.A18324@Odin.AC.HMC.Edu> Brooks Davis writes: : On Wed, Apr 24, 2002 at 08:30:12AM -0700, Warner Losh wrote: : > imp 2002/04/24 08:30:12 PDT : > : > Modified files: : > sys/i386/pci pci_cfgreg.c : > Log: : > o Work around bugs in the powerof2 macro: It thinks that 0 is a power of : > 2, but that's not the case. This fixes the case where there were slots : > in the PIR table that had no bits set, but we assumed they did and used : > strange results as a result. : > o Map invalid INTLINE registers to 255 in pci_cfgreg.c. This should allow : > us to remove the bogus checks in MI code for non-255 values. : > : > I put these changes out for review a while ago, but no one responded : > to them, so into current they go. : : After a month of not having time to do anything about it and looking down : the wrong path several times, I found that the second part of this commit : hoses my HP Omnibook 500. The symptom is that the console doesn't flush : except when the kernel prints something and other timers don't seem to : fire so dhcp hangs forever. Any idea how to debug this? What bogus value is mapping to 255? Sounds like we're now maybe routing an interrupt to something that didn't have/want one before. First step would be to do a before/after test and see which devices, if any, get a new interrupt. Next best would be to send me a dmesg before/after and I can help you interpret it. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message