From owner-freebsd-current  Thu Mar  7  1:36:53 2002
Delivered-To: freebsd-current@freebsd.org
Received: from wint.itfs.nsk.su (wint.itfs.nsk.su [212.20.32.43])
	by hub.freebsd.org (Postfix) with ESMTP id 92BE437B431
	for <current@FreeBSD.ORG>; Thu,  7 Mar 2002 01:36:34 -0800 (PST)
Received: from wint.itfs.nsk.su (localhost [127.0.0.1])
	by wint.itfs.nsk.su (8.12.2/8.12.2) with ESMTP id g279aRHv000688
	for <current@FreeBSD.ORG>; Thu, 7 Mar 2002 15:36:27 +0600 (NOVT)
	(envelope-from nnd@wint.itfs.nsk.su)
Received: (from nnd@localhost)
	by wint.itfs.nsk.su (8.12.2/8.12.2/Submit) id g279aRut000687;
	Thu, 7 Mar 2002 15:36:27 +0600 (NOVT)
Date: Thu, 7 Mar 2002 15:36:27 +0600 (NOVT)
Message-Id: <200203070936.g279aRut000687@wint.itfs.nsk.su>
From: nnd@mail.nsk.ru (Nickolay Dudorov)
To: current@FreeBSD.ORG
Subject: Re: cvs commit: src/lib/libcrypt crypt-md5.c crypt.c crypt.h misc.c         src/secure/lib/libcrypt blowfish.c blowfish.h crypt-blowfish.c         crypt-des.c
In-Reply-To: <200203061718.g26HI9060426@freefall.freebsd.org>
User-Agent: tin/1.5.11-20011225 ("Darkcell") (UNIX) (FreeBSD/5.0-CURRENT (i386))
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

In article <200203061718.g26HI9060426@freefall.freebsd.org>
Mark Murray <markm@FreeBSD.ORG> wrote:
> markm       2002/03/06 09:18:09 PST
> 
>  Modified files:
>    lib/libcrypt         crypt-md5.c crypt.c crypt.h misc.c 
>    secure/lib/libcrypt  blowfish.c blowfish.h crypt-blowfish.c 
>                         crypt-des.c 
>  Log:
>  No functional change, but big code cleanup. WARNS, lint(1) and style(9).

	This comment is false. On my -CURRENT system with
this commit in place 'passwd' and 'login'/'su' commands
loops forever computing MD5 password.

	After reverting crypt-md5.c to rev. 1.8 all thouse
commands work as always.

	Was this cleanup tested ?

	N.Dudorov

>  
>  Revision  Changes    Path
>  1.9       +47 -47    src/lib/libcrypt/crypt-md5.c
>  1.22      +9 -7      src/lib/libcrypt/crypt.c
>  1.7       +2 -2      src/lib/libcrypt/crypt.h
>  1.3       +6 -5      src/lib/libcrypt/misc.c
>  1.3       +13 -110   src/secure/lib/libcrypt/blowfish.c
>  1.2       +13 -13    src/secure/lib/libcrypt/blowfish.h
>  1.3       +26 -59    src/secure/lib/libcrypt/crypt-blowfish.c
>  1.16      +40 -34    src/secure/lib/libcrypt/crypt-des.c
> 

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message