From owner-freebsd-ports@FreeBSD.ORG Thu Jun 13 18:02:47 2013 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id F3CC06CF for ; Thu, 13 Jun 2013 18:02:46 +0000 (UTC) (envelope-from ohauer@gmx.de) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by mx1.freebsd.org (Postfix) with ESMTP id 845751ADD for ; Thu, 13 Jun 2013 18:02:46 +0000 (UTC) Received: from mailout-de.gmx.net ([10.1.76.34]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0MF6cH-1UXYmb4AoN-00GHFl for ; Thu, 13 Jun 2013 20:02:38 +0200 Received: (qmail invoked by alias); 13 Jun 2013 18:02:38 -0000 Received: from p578be941.dip0.t-ipconnect.de (EHLO [192.168.0.100]) [87.139.233.65] by mail.gmx.net (mp034) with SMTP; 13 Jun 2013 20:02:38 +0200 X-Authenticated: #1956535 X-Provags-ID: V01U2FsdGVkX1+c1b9vtTickQ/wrdyzRnm6KtdouAYFFKC1Qs9ns3 74fsmlRm8YFojG Message-ID: <51BA093E.9090303@gmx.de> Date: Thu, 13 Jun 2013 20:02:38 +0200 From: olli hauer User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Baptiste Daroussin Subject: Re: [CFT] Fixing/changing LIB_DEPENDS References: <20130613130730.GK99460@ithaqua.etoilebsd.net> <51B9FA28.3020303@gmx.de> <20130613175005.GC44980@ithaqua.etoilebsd.net> In-Reply-To: <20130613175005.GC44980@ithaqua.etoilebsd.net> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 Cc: ports@FreeBSD.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Jun 2013 18:02:47 -0000 On 2013-06-13 19:50, Baptiste Daroussin wrote: > On Thu, Jun 13, 2013 at 06:58:16PM +0200, olli hauer wrote: >> On 2013-06-13 15:07, Baptiste Daroussin wrote: >>> Hi, >>> >>> Here is a patch to fix LIB_DEPENDS. >>> >>> First what is/are the problem of LIB_DEPENDS. >>> >>> LIB_DEPENDS relies on of ldconfig -r to get its valid or not installed shared >>> libraries, problem is: >>> liba-5.2.so and liba-5.so.2 will both be a-5.2 for ldconfig -r, which is not >>> really what we want. >>> >>> secondly ldconfig -r is only able to print something for libraries in the form >>> of: lib.so[.number], while we have no technical limitation to enforce this >>> form and it is more and more common to find libraries in the following form: >>> lib.so.major.minor.patch and to get them working properly right know we >>> have to patch the upstream build system, to send some magic tricks on libtool >>> etc, all that kind of things all of us loves to deal with. >>> >>> What I do propose is a new form of LIB_DEPENDS in addition to the current one: >>> LIB_DEPENDS= bla.so[numberwithlongorwhatever]:${PORTSDIR}/cat/bla >>> >>> What the framework will do, is lookup in all libraries directories for >>> libbla.so[numberwithdotsorwhatever] test if it exists (test -f also validate the >>> symlink is pointing to a regular file) if /usr/bin/file is present on your >>> system it will validate the pointed file is really a shared library. >>> >>> Any review welcome: http://people.freebsd.org/~bapt/fix-libdepends.patch >>> >>> This idea behind this patch is on mid/long term to remove the other LIB_DEPENDS >>> forms. >>> >>> I do plan to commit this on next friday 2013-06-21. >>> >>> regards, >>> Bapt >>> >> >> >> >> Hm, >> >> so this is a modern extended incarnation of the old LIB_DEPENDS notation >> For example pcre.3:... becomes pcre:... >> >> Isn't this something that can be handled with some additional code in pathfix? >> >> -- >> regards, >> olli >> > > Either I m missing something, or I don't see the point about pathfix. > > It is not a matter of path, but rather allowing the ports tree to handle > properly all kind of library name, right now we have some false limitation and > library name collision because we wrongly rely on ldconfig -r. > > we have lots of patches so convert library names to a format > libname.so.asinglenumber, just for the sake of a technical limitation of the > ports tree. > > That is what I m trying to fix. > > regards, > Bapt > Sorry, I was meaning USE_GNOME=ltverhack not gnomehack ... for example in www/neon we use it to change libneon.so.29 to libneon.so.27 I haven't tested what is the result with a library that comes with so.x.x but maybe ltverhack works also there. -- regards, olli