From owner-freebsd-current Mon Mar 9 18:36:27 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id SAA11808 for freebsd-current-outgoing; Mon, 9 Mar 1998 18:36:27 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from parkplace.cet.co.jp (parkplace.cet.co.jp [202.32.64.1]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id SAA11798 for ; Mon, 9 Mar 1998 18:36:24 -0800 (PST) (envelope-from michaelh@cet.co.jp) Received: from localhost (michaelh@localhost) by parkplace.cet.co.jp (8.8.8/CET-v2.2) with SMTP id CAA28704; Tue, 10 Mar 1998 02:35:19 GMT Date: Tue, 10 Mar 1998 11:35:19 +0900 (JST) From: Michael Hancock To: Dmitrij Tejblum cc: Terry Lambert , current@FreeBSD.ORG Subject: Re: vnode_pager: *** WARNING *** stale FS code in system In-Reply-To: <199803092359.CAA03508@tejblum.dnttm.rssi.ru> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG I think vnode_pager_generic_(put|get)pages should be moved to vfs_default.c and renamed vop_std(put|get)pages. It would need to be modified to accept ap instead of 4 components of ap. Terry is trying to make it more visible to fs implementors so that they take the time to understand how to make VM friendly implementations. The "XXX - wimp out ..." comment is also added for extra emphasis. This comment should be taken out and replaced by a comment explaining what a VM friendly (get|put)pages should do. I think vfs_default.c is visible enough. This is a form discussion, the substance is the same. My personal opinion is that it doesn't belong vnode_pager.c because it will tend to be ignored by fs implementors. Regards, Mike Hancock To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message