From owner-cvs-all  Tue Jul  3 10:33:50 2001
Delivered-To: cvs-all@freebsd.org
Received: from sax.sax.de (sax.sax.de [193.175.26.33])
	by hub.freebsd.org (Postfix) with ESMTP
	id D829E37B403; Tue,  3 Jul 2001 10:33:42 -0700 (PDT)
	(envelope-from j@uriah.heep.sax.de)
Received: (from uucp@localhost)
	by sax.sax.de (8.9.3/8.9.3) with UUCP id TAA17492;
	Tue, 3 Jul 2001 19:33:41 +0200 (CEST)
Received: (from j@localhost)
	by uriah.heep.sax.de (8.11.4/8.11.4) id f63HWET07464;
	Tue, 3 Jul 2001 19:32:14 +0200 (MET DST)
	(envelope-from j)
Date: Tue, 3 Jul 2001 19:32:14 +0200
From: Joerg Wunsch <j@uriah.heep.sax.de>
To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/sys bio.h
Message-ID: <20010703193214.A3398@uriah.heep.sax.de>
Reply-To: Joerg Wunsch <joerg_wunsch@uriah.heep.sax.de>
References: <200106291521.f5TFLUT83063@freefall.freebsd.org> <200107030615.f636FLU07187@mass.dis.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 1.0.1i
In-Reply-To: <200107030615.f636FLU07187@mass.dis.org>; from msmith@FreeBSD.org on Mon, Jul 02, 2001 at 11:15:21PM -0700
X-Phone: +49-351-2012 669
X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F  93 21 E0 7D F9 12 D6 4E
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

As Mike Smith wrote:

> >     sys/sys              bio.h 
> >   Log:
> >   Define BIO_CMD{1,2}, available for local hacks, similar to the already
> >   existing BIO_FLAG{1,2}.  To be used in the fdc(4) driver soon.
> 
> Any reason you're not using the driver-private field instead?

Because i need to fill in a cmd value anyway, and neither of the
existing didn't fit well.  Maybe a single CMD_PRIVATE value would have
sufficed, but i rather followed the other examples (CMD_FLAG{1,2}
etc).

Also, using a void * would have complicated matters pretty much.  It's
invalid to abuse a void * as an int, so i would have had to malloc a
single 32-bit value somewhere since i can't use a variable located on
the stack, and pass its address down in one of the void * field.

-- 
cheers, J"org               .-.-.   --... ...--   -.. .  DL8DTL

http://www.sax.de/~joerg/                        NIC: JW11-RIPE
Never trust an operating system you don't have sources for. ;-)

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message