From owner-cvs-src@FreeBSD.ORG Wed Sep 28 09:13:08 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5A64316A41F; Wed, 28 Sep 2005 09:13:08 +0000 (GMT) (envelope-from tataz@tataz.chchile.org) Received: from smtp1-g19.free.fr (smtp1-g19.free.fr [212.27.42.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id F3E2743D49; Wed, 28 Sep 2005 09:13:07 +0000 (GMT) (envelope-from tataz@tataz.chchile.org) Received: from tatooine.tataz.chchile.org (vol75-8-82-233-239-98.fbx.proxad.net [82.233.239.98]) by smtp1-g19.free.fr (Postfix) with ESMTP id F08422FBED; Wed, 28 Sep 2005 11:13:06 +0200 (CEST) Received: by tatooine.tataz.chchile.org (Postfix, from userid 1000) id A20EB4083; Wed, 28 Sep 2005 11:13:08 +0200 (CEST) Date: Wed, 28 Sep 2005 11:13:08 +0200 From: Jeremie Le Hen To: "Christian S.J. Peron" Message-ID: <20050928091308.GA2151@obiwan.tataz.chchile.org> References: <200509280030.j8S0UuME056018@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200509280030.j8S0UuME056018@repoman.freebsd.org> User-Agent: Mutt/1.5.10i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_jail.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Sep 2005 09:13:08 -0000 Hi Christian, On Wed, Sep 28, 2005 at 12:30:56AM +0000, Christian S.J. Peron wrote: > csjp 2005-09-28 00:30:56 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_jail.c > Log: > Push Giant down in jails. Pass the MPSAFE flag to NDINIT, and keep track > of whether or not Giant was picked up by the filesystem. Add VFS_LOCK_GIANT > macros around vrele as it's possible that this can call in the VOP_INACTIVE > filesystem specific code. Also while we are here, remove the Giant assertion. > from the sysctl handler, we do not actually require Giant here so we > shouldn't assert it. Doing so will just complicate things when Giant is removed > from the sysctl framework. Do you plan to MFC this to RELENG_6 ? Regards, -- Jeremie Le Hen < jeremie at le-hen dot org >< ttz at chchile dot org >