From nobody Tue Feb 3 10:38:56 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f50My3w6rz6PM2s; Tue, 03 Feb 2026 10:39:10 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4f50Mx3Y78z3Hhk; Tue, 03 Feb 2026 10:39:09 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 613AcuJ4013595; Tue, 3 Feb 2026 12:39:00 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 613AcuJ4013595 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 613AculT013594; Tue, 3 Feb 2026 12:38:56 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 3 Feb 2026 12:38:56 +0200 From: Konstantin Belousov To: Abdelkader Boudih Cc: "Enji Cooper (yaneurabeya)" , Adrian Chadd , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 052a791b0055 - main - acpi: add Darwin OSI quirk for Apple Mac hardware Message-ID: References: <698154c0.35e9d.2d7b8775@gitrepo.freebsd.org> <0A69735E-8BF6-41B1-AB7A-9B761A0FF158@gmail.com> <63ee9a06-97bd-4f7f-8bb8-ed39382d94a4@app.fastmail.com> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <63ee9a06-97bd-4f7f-8bb8-ed39382d94a4@app.fastmail.com> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.2 X-Spam-Checker-Version: SpamAssassin 4.0.2 (2025-08-27) on tom.home X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Queue-Id: 4f50Mx3Y78z3Hhk X-Spamd-Bar: ---- On Tue, Feb 03, 2026 at 11:08:40AM +0100, Abdelkader Boudih wrote: > I agree that this should not be permanent verbosity. > > The aim was not to add long-term noise, but to make the behavior observable/greppable to reviewers while this logic is still being validated across a wide range of Apple models. > > I'm going to get few Apple devices to try on. Once we confirm that every model behave the same, we could totally remove verbosity and treating it as assumed-working code. > > > On Tue, 3 Feb 2026, at 08:56, Konstantin Belousov wrote: > > On Mon, Feb 02, 2026 at 10:41:58PM -0800, Enji Cooper (yaneurabeya) wrote: > > > > > > > On Feb 2, 2026, at 9:33 PM, Konstantin Belousov wrote: > > > > > > ... > > > > > > >> + if (ACPI_SUCCESS(status)) { > > > >> + device_printf(dev, > > > >> + "Apple hardware: installed Darwin " > > > >> + "OSI and removed other vendor OSI " > > > >> + "(Windows, etc)\n"); > > > > Why this verbosity is needed? > > > > > > > > I see no benefit from it, other then consuming kernel memory. > > > > > > I added the verbosity. It helped a few of us Apple users determine whether or not the functionality was working. I can trim down the verbosity if needed in a followup commit. > > > > Yes, I think that this verbosity is not warranted. If you want something > > to be printed, much shorter messages would be enough. But I am not sure > > that any messaging is needed. > > Note that there are two things. One is the overly long and IMO unhelpful musing about what happen: what is installed, and what is removed, and especially the 'Windows, etc' part. This can be shortened to simple informational message, that allows to identify the successful action, without musing about its origin and possible effects. Another is the removal of the printing at all. I am sure that the first issue should be fixed now, if some informational printing is going to stay for (limited) time.