From owner-freebsd-toolchain@FreeBSD.ORG Wed Jun 17 02:18:42 2015 Return-Path: Delivered-To: freebsd-toolchain@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B1859B80 for ; Wed, 17 Jun 2015 02:18:42 +0000 (UTC) (envelope-from daemon-user@FreeBSD.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 92403DBE for ; Wed, 17 Jun 2015 02:18:42 +0000 (UTC) (envelope-from daemon-user@FreeBSD.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t5H2Igrt096075 for ; Wed, 17 Jun 2015 02:18:42 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t5H2IgEb096074; Wed, 17 Jun 2015 02:18:42 GMT (envelope-from daemon-user) Date: Wed, 17 Jun 2015 02:18:42 +0000 To: freebsd-toolchain@freebsd.org From: "araujo (Marcelo Araujo)" Reply-to: D2690+334+b4a053d3a7c96652@FreeBSD.org Subject: [Differential] [Commented On] D2690: In ypbind, eliminate error: dereferencing type-punned pointer will break strict-aliasing rules Message-ID: X-Priority: 3 Thread-Topic: D2690: In ypbind, eliminate error: dereferencing type-punned pointer will break strict-aliasing rules X-Herald-Rules: <28> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2M3ODgwNzhlNGU0M2Q5NjMyZTYwOGZmMTc0IFWA2QI= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 02:18:42 -0000 araujo added a comment. In https://reviews.freebsd.org/D2690#54413, @rodrigc wrote: > Sorry for the late response. Please address @dim 's comment, if you have not > addressed it already. Yes, I have addressed @dim's comment already. > Also, removing the type-alias punned warnings is trickier than the other types > of fixes that we have done to clean up the code. > For this change, I would feel more comfortable if we actually tested ypbind with this code change. > > I know, this is a headcahe. :( > But still, we have to do the right thing. I would prefer make it in two steps, first fix the CLANG issues with this patch, I will make the tests and report to you as soon as I get the results. You are right and we must do it. > Regarding importing ypbind from OpenBSD. I think this is a good idea, because it looks like they more actively maintain the code. > However, this code in FreeBSD is *old*....almost 17 years old. Even if we import from OpenBSD, I don't know if > there are changes to functionality, command-line options, etc. that will be introduced. > This will require testing also. > > It depends on how much interest you have in ypbind. :) > I don't have a lot of interest, and was just looking at doing minimal code changes to fix compiler warnings. > > Let me know what approach you want to take. I will support you. I don't have too many interest on ypbind, but I do believe to sync it with OpenBSD won't be that hard, but will cost time. I will do it in a second time, first I will check what are the changes and the impact as we are using a very old ypbind. Thanks for the support, very appreciated, I will start it soon. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D2690 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: rodrigc, bapt, emaste, dim, araujo Cc: imp, freebsd-toolchain-list