From owner-cvs-all@FreeBSD.ORG Mon Mar 31 11:37:46 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1577A37B401; Mon, 31 Mar 2003 11:37:46 -0800 (PST) Received: from k6.locore.ca (k6.locore.ca [198.96.117.170]) by mx1.FreeBSD.org (Postfix) with ESMTP id B616943FA3; Mon, 31 Mar 2003 11:37:44 -0800 (PST) (envelope-from jake@k6.locore.ca) Received: from k6.locore.ca (localhost.locore.ca [127.0.0.1]) by k6.locore.ca (8.12.8/8.12.8) with ESMTP id h2VJiDxS038576; Mon, 31 Mar 2003 14:44:13 -0500 (EST) (envelope-from jake@k6.locore.ca) Received: (from jake@localhost) by k6.locore.ca (8.12.8/8.12.8/Submit) id h2VJiDqB038575; Mon, 31 Mar 2003 14:44:13 -0500 (EST) Date: Mon, 31 Mar 2003 14:44:13 -0500 From: Jake Burkholder To: Nate Lawson Message-ID: <20030331194413.GA37842@locore.ca> References: <200303311729.h2VHTi9k095144@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200303311729.h2VHTi9k095144@repoman.freebsd.org> User-Agent: Mutt/1.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c if_wb.c if_xl.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Mar 2003 19:37:49 -0000 Apparently, On Mon, Mar 31, 2003 at 09:29:44AM -0800, Nate Lawson said words to the effect of; > njl 2003/03/31 09:29:44 PST > > FreeBSD src repository > > Modified files: > sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c > if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c > if_wb.c if_xl.c > Log: > Clean up locking and resource management for pci/if_* > Seems like the same broken KASSERT was cut and pasted into all of these: Index: pci/if_rl.c =================================================================== RCS file: /home/ncvs/src/sys/pci/if_rl.c,v retrieving revision 1.91 diff -u -r1.91 if_rl.c --- pci/if_rl.c 31 Mar 2003 17:29:43 -0000 1.91 +++ pci/if_rl.c 31 Mar 2003 19:18:54 -0000 @@ -1103,7 +1103,7 @@ struct ifnet *ifp; sc = device_get_softc(dev); - KASSERT(mtx_initialized(&sc->rl_mtx), "rl mutex not initialized"); + KASSERT(mtx_initialized(&sc->rl_mtx), ("rl mutex not initialized")); RL_LOCK(sc); ifp = &sc->arpcom.ac_if; Index: pci/if_xl.c =================================================================== RCS file: /home/ncvs/src/sys/pci/if_xl.c,v retrieving revision 1.135 diff -u -r1.135 if_xl.c --- pci/if_xl.c 31 Mar 2003 17:29:43 -0000 1.135 +++ pci/if_xl.c 31 Mar 2003 19:19:34 -0000 @@ -1740,7 +1740,7 @@ int rid, res; sc = device_get_softc(dev); - KASSERT(mtx_initialized(&sc->xl_mtx), "xl mutex not initialized"); + KASSERT(mtx_initialized(&sc->xl_mtx), ("xl mutex not initialized")); XL_LOCK(sc); ifp = &sc->arpcom.ac_if; etc. Jake