Date: Mon, 9 Dec 2013 17:55:34 GMT From: Matthieu Volat <mazhe@alkumuna.eu> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/184639: [patch] net/mDNSResponder build with yacc (bison not needed) Message-ID: <201312091755.rB9HtYDr033657@oldred.freebsd.org> Resent-Message-ID: <201312091800.rB9I00q3064550@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 184639 >Category: ports >Synopsis: [patch] net/mDNSResponder build with yacc (bison not needed) >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Dec 09 18:00:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Matthieu Volat >Release: 9.2-RELEASE >Organization: >Environment: FreeBSD freedom.alkumuna.eu 9.2-RELEASE FreeBSD 9.2-RELEASE #0 r255898: Thu Sep 26 22:50:31 UTC 2013 root@bake.isc.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64 >Description: I have noticed by chance that parser files in net/mDNSResponder are in fact well writen and will work with base yacc implementation, thus do not require devel/bison to build. I've attached a patch that remove the dependency and change the BISON value. >How-To-Repeat: >Fix: See enclosed patch: 1. remove bison in use flags 2. set BISON value to yacc in mDNSPosix/Makefile Patch attached with submission follows: diff -ru mDNSResponder.orig/Makefile mDNSResponder/Makefile --- mDNSResponder.orig/Makefile 2013-12-09 18:21:53.000000000 +0100 +++ mDNSResponder/Makefile 2013-12-09 18:22:32.000000000 +0100 @@ -17,7 +17,7 @@ BUILD_WRKSRC= ${WRKSRC}/mDNSPosix INSTALL_WRKSRC= ${WRKSRC}/mDNSPosix MAKE_ARGS= LOCALBASE=${PREFIX} MANPATH=${MANPREFIX}/man os=freebsd -USES= bison gmake +USES= gmake USE_LDCONFIG= yes USE_RC_SUBR= mdnsd mdnsresponder diff -ru mDNSResponder.orig/files/patch-mDNSPosix-Makefile mDNSResponder/files/patch-mDNSPosix-Makefile --- mDNSResponder.orig/files/patch-mDNSPosix-Makefile 2013-12-09 18:21:53.000000000 +0100 +++ mDNSResponder/files/patch-mDNSPosix-Makefile 2013-12-09 18:39:59.000000000 +0100 @@ -1,5 +1,5 @@ ---- mDNSPosix/Makefile.orig 2011-11-03 08:23:39.000000000 +0800 -+++ mDNSPosix/Makefile 2013-10-13 02:29:12.791431406 +0800 +--- mDNSPosix/Makefile.orig 2012-10-18 00:11:12.000000000 +0200 ++++ mDNSPosix/Makefile 2013-12-09 18:39:26.000000000 +0100 @@ -54,7 +54,7 @@ SHAREDDIR ?= ../mDNSShared JDK = /usr/jdk @@ -18,7 +18,15 @@ # FreeBSD 4 requires threaded code to be compiled and linked using the "-pthread" option, # and requires that the "-lpthread" link option NOT be used # This appies only to FreeBSD -- "man cc" on FreeBSD says: -@@ -216,7 +216,7 @@ +@@ -133,6 +133,7 @@ + LINKOPTS_PTHREAD = -pthread + JAVACFLAGS_OS += -I$(JDK)/include/freebsd + LDCONFIG = ldconfig ++BISON = @yacc + else + + ifeq ($(os),openbsd) +@@ -216,7 +217,7 @@ all: setup Daemon libdns_sd Clients SAClient SAResponder SAProxyResponder Identify NetMonitor dnsextd $(OPTIONALTARG) @@ -27,7 +35,7 @@ # 'setup' sets up the build directory structure the way we want setup: -@@ -259,10 +259,10 @@ +@@ -259,10 +260,10 @@ @$(LD) $(LINKOPTS) -o $@ $+ @$(STRIP) $@ @@ -40,7 +48,7 @@ @$(MAKE) -C ../Clients # nss_mdns target builds the Name Service Switch module -@@ -276,43 +276,43 @@ +@@ -276,43 +277,43 @@ ############################################################################# # The Install targets place built stuff in their proper places @@ -95,7 +103,7 @@ $(CP) $< $@ chmod ugo+x $@ $@ start -@@ -329,26 +329,26 @@ +@@ -329,26 +330,26 @@ endif endif @@ -128,7 +136,7 @@ $(CP) $< $@ chmod 444 $@ -@@ -490,6 +490,8 @@ +@@ -490,6 +491,8 @@ $(BUILDDIR)/dnsextd: $(DNSEXTDOBJ) $(OBJDIR)/dnsextd.c.threadsafe.o $(CC) $+ -o $@ $(LINKOPTS) $(LINKOPTS_PTHREAD) >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312091755.rB9HtYDr033657>