From owner-cvs-src@FreeBSD.ORG Thu Feb 15 20:02:10 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1951816A406; Thu, 15 Feb 2007 20:02:10 +0000 (UTC) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.188]) by mx1.freebsd.org (Postfix) with ESMTP id 9E1A213C467; Thu, 15 Feb 2007 20:02:09 +0000 (UTC) (envelope-from max@love2party.net) Received: from [88.66.16.42] (helo=amd64.laiers.local) by mrelayeu.kundenserver.de (node=mrelayeu1) with ESMTP (Nemesis), id 0MKwpI-1HHmnw0NNd-0002vl; Thu, 15 Feb 2007 21:02:08 +0100 From: Max Laier Organization: FreeBSD To: Luigi Rizzo Date: Thu, 15 Feb 2007 21:01:57 +0100 User-Agent: KMail/1.9.5 References: <200702151949.l1FJnSnp061671@repoman.freebsd.org> In-Reply-To: <200702151949.l1FJnSnp061671@repoman.freebsd.org> X-Face: ,,8R(x[kmU]tKN@>gtH1yQE4aslGdu+2]; R]*pL,U>^H?)gW@49@wdJ`H<=?utf-8?q?=25=7D*=5FBD=0A=09U=5For=3D=5CmOZf764=26nYj=3DJYbR1PW0ud?=>|!~,,CPC.1-D$FG@0h3#'5"k{V]a~.<=?utf-8?q?mZ=7D44=23Se=7Em=0A=09Fe=7E=5C=5DX5B=5D=5Fxj?=(ykz9QKMw_l0C2AQ]}Ym8)fU MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2390401.XFYGKt9TvH"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200702152102.06506.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de login:61c499deaeeba3ba5be80f48ecc83056 X-Provags-ID2: V01U2FsdGVkX1+0xd/7d8vaxIvaHKSaLfoxOoHze4Wd2cxdoj6hxUYbOFUANZyuwpVPnFhj6ksfqch38RoCIzSCLPx+SROwrtbhzM/9rRCrrIsB0jskz6TocA== Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/digi digi.c src/sys/kern kern_linker.c subr_firmware.c src/sys/sys linker.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Feb 2007 20:02:10 -0000 --nextPart2390401.XFYGKt9TvH Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Thursday 15 February 2007 20:49, Luigi Rizzo wrote: > luigi 2007-02-15 19:49:27 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/dev/digi digi.c > sys/kern kern_linker.c subr_firmware.c > sys/sys linker.h > Log: > MFC kern_linker.c 1.133 and related changes: > > - push Giant into linker_reference_module(); > - introduce linker_release_module(), which also takes care of > proper locking. > > The latter also fixes a missing mtx_loc/unlock in subr_firmware.c . > > Apparently, digi.c is the only external client of > linker_reference_module() which is a bit suspicious - perhaps dev/digi/ > could make with a bit of review from someone knowledgeable to check how > the function is used, and whether it could be replaced by something > else. I have a version of digi(4) in perforce that uses firmware(9). I couldn't= =20 find testers, but with a bit of review this should be committable=20 nonetheless. =20 http://perforce.freebsd.org/depotTreeBrowser.cgi?FSPC=3D//depot/user/mlaier= /firmware/sys/dev/digi/&HIDEDEL=3DNO > Revision Changes Path > 1.58.2.3 +3 -3 src/sys/dev/digi/digi.c > 1.117.2.2 +31 -1 src/sys/kern/kern_linker.c > 1.1.2.4 +1 -3 src/sys/kern/subr_firmware.c > 1.39.2.2 +8 -0 src/sys/sys/linker.h =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart2390401.XFYGKt9TvH Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQBF1Lw+XyyEoT62BG0RAtGXAJ9tVkvpNPtLz8n/nCvuO9BtT1bb/ACfRacf /rXXgQeKgxDQ/cWh3XhrdZU= =P+rY -----END PGP SIGNATURE----- --nextPart2390401.XFYGKt9TvH--