From owner-freebsd-usb@FreeBSD.ORG Thu Apr 19 06:04:17 2007 Return-Path: X-Original-To: freebsd-usb@freebsd.org Delivered-To: freebsd-usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 99B9D16A402 for ; Thu, 19 Apr 2007 06:04:17 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from mail.turbocat.net (mail.turbocat.net [213.133.116.130]) by mx1.freebsd.org (Postfix) with ESMTP id 1F8F713C48C for ; Thu, 19 Apr 2007 06:04:17 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: by mail.turbocat.net (Postfix, from userid 1002) id 76DC7422EC4D; Thu, 19 Apr 2007 08:04:06 +0200 (CEST) Received: from laptop.lan (c983ABF51.dhcp.bluecom.no [81.191.58.152]) by mail.turbocat.net (Postfix) with ESMTP id 33DB1422EC30; Thu, 19 Apr 2007 08:04:05 +0200 (CEST) From: Hans Petter Selasky To: freebsd-usb@freebsd.org Date: Thu, 19 Apr 2007 08:03:42 +0200 User-Agent: KMail/1.9.5 References: <200703290011.l2T0BAKa035949@www.freebsd.org> <200704061744.07179.hselasky@c2i.net> <4626BDC2.7060904@bindone.de> In-Reply-To: <4626BDC2.7060904@bindone.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200704190803.42310.hselasky@c2i.net> Cc: Subject: Re: usb/110988: [patch] Handling of quirk IGNORE_RESIDUE is umass.c is broken X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2007 06:04:17 -0000 On Thursday 19 April 2007 02:54, grem wrote: > Hans Petter Selasky wrote: > > On Friday 06 April 2007 16:56, grem wrote: > >> Hans Petter Selasky wrote: > >>> On Wednesday 04 April 2007 16:09, grem wrote: > >>>> Hi, > >>>> > >>>> is there any way to get this into the source tree? > >>> > >>> Yes, I can take this patch into the P4 tree if you change it a little > >>> bit. > >>> > >>> I want this invalid residue detection to be all automatic: > >>> > >>> If the first residue you get is invalid, then it should use the USB > >>> transfer counts for residue for the rest of the lifetime of the device. > >>> Else it should use the standard invalid residue check. > >>> > >>> --HPS > >> > >> Imho we should support both, so that devices which are so broken that we > >> can't detect the invalid residue (like I tried to point out before) > >> still have the quirk so force it manually. > > > > Ok, no problem, but like Alexander Leidinger pointed out, the current > > flag does not do anything, and should be removed from a couple of > > devices. > > > >> Can you do the autodetection on your own or do you want me to do the > >> change to the patch and repost it so you can review? I have only one > >> broken USB device, so if anyone out there has access to more it would be > >> extremely helpful. > > > > I can make a patch for this, and send it to you for testing, during the > > next week. > > > > --HPS > > Any progress? :) Hence I started in a new job this week, I have postponed this to the weekend. I will make a posting to the list when I have got something finished. --HPS