From owner-freebsd-stable@FreeBSD.ORG Thu Dec 13 07:54:18 2012 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C2D98538; Thu, 13 Dec 2012 07:54:18 +0000 (UTC) (envelope-from jmg@h2.funkthat.com) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) by mx1.freebsd.org (Postfix) with ESMTP id 895968FC16; Thu, 13 Dec 2012 07:54:18 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id qBD7Yx6C025140 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 12 Dec 2012 23:34:59 -0800 (PST) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id qBD7Yxqw025139; Wed, 12 Dec 2012 23:34:59 -0800 (PST) (envelope-from jmg) Date: Wed, 12 Dec 2012 23:34:58 -0800 From: John-Mark Gurney To: Jim Harris Subject: Re: tws bug ? (LSI SAS 9750) Message-ID: <20121213073458.GB1563@funkthat.com> Mail-Followup-To: Jim Harris , Jim Harris , Mike Tancsa , FreeBSD-STABLE Mailing List , delphij@freebsd.org References: <505CC8EC.4030608@sentex.net> <505CE601.4070106@sentex.net> <505D0846.8050108@sentex.net> <20121026201819.GF1563@funkthat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Wed, 12 Dec 2012 23:34:59 -0800 (PST) Cc: delphij@freebsd.org, Jim Harris , FreeBSD-STABLE Mailing List X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2012 07:54:18 -0000 Jim Harris wrote this message on Fri, Oct 26, 2012 at 13:24 -0700: > On Fri, Oct 26, 2012 at 1:18 PM, John-Mark Gurney wrote: > > > > I'm seeing similar stuff on the hpt27xx driver: > > (probe18:hpt27xx0:0:18:0): INQUIRY. CDB: 12 0 0 0 24 0 > > (probe18:hpt27xx0:0:18:0): CAM status: Invalid Target ID > > (probe18:hpt27xx0:0:18:0): Error 22, Unretryable error > > > > Should I make a similar change in sys/dev/hpt27xx/osm_bsd.c? Looks like > > there are two CAM_TID_INVALID lines, but from reading the comments, only > > the second one should change... > > > > Correct? If so, I'll try making the change and make sure everything > > works well. > > > > Yes - I agree that a similar change is needed, and only to the second > one in that file. Ok, I've tested a patch, and so far things look much better... It shuts up all the bad probe messges... Though I ran across a bug where the card went out to lunch giving these messages: (da2:hpt27xx0:0:2:0): READ(10). CDB: 28 0 a5 4c ae d8 0 0 58 0 (da2:hpt27xx0:0:2:0): CAM status: SCSI Status Error (da2:hpt27xx0:0:2:0): SCSI status: OK (da3:hpt27xx0:0:3:0): READ(10). CDB: 28 0 a5 4c b9 f0 0 0 50 0 (da3:hpt27xx0:0:3:0): CAM status: SCSI Status Error (da3:hpt27xx0:0:3:0): SCSI status: OK Scott Long suggested the first part of the patch so that an error is actually generated... Though it would be good for the sense data to be set, but not sure where to get it... Index: osm_bsd.c =================================================================== --- osm_bsd.c (revision 241041) +++ osm_bsd.c (working copy) @@ -453,7 +453,7 @@ ccb->ccb_h.status = CAM_BUSY; break; default: - ccb->ccb_h.status = CAM_SCSI_STATUS_ERROR; + ccb->ccb_h.status = CAM_AUTOSENSE_FAIL; break; } @@ -569,7 +569,7 @@ vd = ldm_find_target(vbus, ccb->ccb_h.target_id); if (!vd) { - ccb->ccb_h.status = CAM_TID_INVALID; + ccb->ccb_h.status = CAM_SEL_TIMEOUT; xpt_done(ccb); return; } -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."