From owner-freebsd-ports@FreeBSD.ORG Wed Aug 29 19:48:47 2012 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C01B6106566C; Wed, 29 Aug 2012 19:48:47 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 5DCD38FC15; Wed, 29 Aug 2012 19:48:47 +0000 (UTC) Received: from outgoing.leidinger.net (p5796D894.dip.t-dialin.net [87.150.216.148]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id C37258444E7; Wed, 29 Aug 2012 21:48:34 +0200 (CEST) Received: from unknown (IO.Leidinger.net [192.168.1.12]) by outgoing.leidinger.net (Postfix) with ESMTPS id 1E12713D5; Wed, 29 Aug 2012 21:48:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=leidinger.net; s=outgoing-alex; t=1346269712; bh=lN9sGexQHyc7JDM1d7/TG5tnDJdVQ+vsXzUlGmY9Svc=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=IOiN0QwF1KCuOwB7C4BiV0awCqXB8ob5i+S1vqXHERuOmHVpLYMiGad31RUZ5SMFU McM6DnyjS2vxvGne0i6nEF4Nf4G2pJqAn4mtGfQjqt9Ewm4lpVOIKEXuKGCtDrfsjl RLkfA29dbkBymCaZkNqKHdZ5Q5E5jkCW1vYEirWoyc/diP93/OekD/rNlLsfatkV4K CiJM2JX54hOEgDxMbSBvA9jqiIr8w2EhnoIpuO7AfxvZTVGLnI/H+bQW5K3fflcVUM eQmD+Y90b1mKdn68xWGfR+C8UmCzQqG7J7vyYndyVQ9K71kEaG5y0RUQFMOik58hBL 2NPERctkLHEPA== Date: Wed, 29 Aug 2012 21:48:31 +0200 From: Alexander Leidinger To: Eitan Adler Message-ID: <20120829214831.000050c8@unknown> In-Reply-To: References: <20120826225435.00005a10@unknown> <20120829211753.0000399e@unknown> X-Mailer: Claws Mail 3.8.0cvs30 (GTK+ 2.24.10; i586-pc-mingw32msvc) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: C37258444E7.A1AC2 X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-0.837, required 6, autolearn=disabled, ALL_TRUSTED -1.00, AWL 0.27, DKIM_SIGNED 0.10, DKIM_VALID -0.10, DKIM_VALID_AU -0.10, T_RP_MATCHES_RCVD -0.01) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1346874515.18649@jXW1Kba3hjQAKZY6A5zzKg X-EBL-Spam-Status: No Cc: ports@freebsd.org, gcooper@freebsd.org, portmgr@freebsd.org Subject: Re: Regression in PREFIX handling in packages X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2012 19:48:47 -0000 On Wed, 29 Aug 2012 15:28:36 -0400 Eitan Adler wrote: > On 29 August 2012 15:17, Alexander Leidinger > wrote: > > Could it be that my problem comes from r231300 and I was lucky that > > I didn't create a package on the machine with the > > symlinked /usr/local and used it on a machine with a > > normal /usr/local? > > I have not been following this thread, so if you traced the bug to > this commit, I'll accept that. It's a guess, I haven't tried to back it out and test again. > > http://svnweb.freebsd.org/base/head/usr.sbin/pkg_install/create/perform.c?r1=228990&r2=231300 > > > > What's the problem this patch tries to solve? Shouldn't the plist > > use the prefix as specified by the env variable instead of the > > realpath? > > The specific problem this patch was trying to solve is to allow the > use of "." or other relative paths in the -p argument to pkg_create. Wouldn't it be better to use ---snip--- if (Prefix[0] != '/' && realpath(... ---snip--- in this case? Attention: I just guessed what Prefix is and what it should contain by looking at the diff, I didn't had a look at the declaraction and assignments of Prefix. Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137