From owner-freebsd-stable@freebsd.org Mon Oct 19 23:32:07 2015 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BE343A192B3 for ; Mon, 19 Oct 2015 23:32:07 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from esa-annu.net.uoguelph.ca (esa-annu.mail.uoguelph.ca [131.104.91.36]) by mx1.freebsd.org (Postfix) with ESMTP id 42D3F1FB; Mon, 19 Oct 2015 23:32:06 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) IronPort-PHdr: 9a23:75eCQBGyJ7Ab1f9OHu3UcJ1GYnF86YWxBRYc798ds5kLTJ75oM+wAkXT6L1XgUPTWs2DsrQf27aQ4v+rAzZIyK3CmU5BWaQEbwUCh8QSkl5oK+++Imq/EsTXaTcnFt9JTl5v8iLzG0FUHMHjew+a+SXqvnYsExnyfTB4Ov7yUtaLyZ/ni6bjpNaJOU1hv3mUX/BbFF2OtwLft80b08NJC50a7V/3mEZOYPlc3mhyJFiezF7W78a0+4N/oWwL46pyv+YJa6jxfrw5QLpEF3xmdjltvIy4/SXEGCCP/HoHTmQflFJrGQHZ/hzgFsP6sQPxtfF61jXcMcCgHp4uXjH31aZgS1fNgSwEMzM8uDXNj8V7j6ZWpTq8oBNizorMYMeePawtLevmYdoGSD8ZDY5qXCtbD9b5NtNXAg== X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2DQAQC9fCVW/61jaINehApvBr4KAQ2BWhcKgkOCcEoCgXUUAQEBAQEBAQGBCYImggcBAQEDAQEBASArIAsFCQICAQgOCgICDRkCAhsMAQkmAgQIBwQBHASIBwgNsWaTBAEBAQEBAQEBAQEBAQEBAQEBARsEgR6FVYR+hCoQAgEcNAeCaYFFBZYjhRmFG4RBllGDbQIfAQFCghEdgXEiNAeEWoEGAQEB X-IronPort-AV: E=Sophos;i="5.17,704,1437451200"; d="scan'208";a="245552460" Received: from nipigon.cs.uoguelph.ca (HELO zcs1.mail.uoguelph.ca) ([131.104.99.173]) by esa-annu.net.uoguelph.ca with ESMTP; 19 Oct 2015 19:31:59 -0400 Received: from localhost (localhost [127.0.0.1]) by zcs1.mail.uoguelph.ca (Postfix) with ESMTP id DB48A15F55D; Mon, 19 Oct 2015 19:31:59 -0400 (EDT) Received: from zcs1.mail.uoguelph.ca ([127.0.0.1]) by localhost (zcs1.mail.uoguelph.ca [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id o3MoDRhyZJvp; Mon, 19 Oct 2015 19:31:59 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by zcs1.mail.uoguelph.ca (Postfix) with ESMTP id 3164F15F565; Mon, 19 Oct 2015 19:31:59 -0400 (EDT) X-Virus-Scanned: amavisd-new at zcs1.mail.uoguelph.ca Received: from zcs1.mail.uoguelph.ca ([127.0.0.1]) by localhost (zcs1.mail.uoguelph.ca [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id mwuFqSZrvV_5; Mon, 19 Oct 2015 19:31:59 -0400 (EDT) Received: from zcs1.mail.uoguelph.ca (zcs1.mail.uoguelph.ca [172.17.95.18]) by zcs1.mail.uoguelph.ca (Postfix) with ESMTP id 1753515F55D; Mon, 19 Oct 2015 19:31:59 -0400 (EDT) Date: Mon, 19 Oct 2015 19:31:59 -0400 (EDT) From: Rick Macklem To: Christian Kratzer Cc: freebsd-stable@freebsd.org, John Baldwin Message-ID: <991652190.43412204.1445297519046.JavaMail.zimbra@uoguelph.ca> In-Reply-To: References: <2135054744.32546564.1444653156980.JavaMail.zimbra@uoguelph.ca> <173739656.33429352.1444704458926.JavaMail.zimbra@uoguelph.ca> <1459207327.41372204.1445174292836.JavaMail.zimbra@uoguelph.ca> Subject: Re: smbfs crashes since approx. 10.1-RELEASE MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [172.17.95.12] X-Mailer: Zimbra 8.0.9_GA_6191 (ZimbraWebClient - FF34 (Win)/8.0.9_GA_6191) Thread-Topic: smbfs crashes since approx. 10.1-RELEASE Thread-Index: WUN8hXhDJz6R1ox3ccCd38H4Ipv3lg== X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Oct 2015 23:32:07 -0000 Christian Kratzer wrote: > Hi Rick, > > On Sun, 18 Oct 2015, Rick Macklem wrote: > > > Christian Kratzer wrote: > >> Hi Rick, > >> > >> looks like your latest patch nailed the issue. The box has been up for 3 > >> days: > >> > >> ck@noc3:~ % uptime > >> 12:22PM up 3 days, 4:11, 1 user, load averages: 0.07, 0.10, 0.08 > >> ck@noc3:~ % > >> > >> If it does not crash over the weekend this seems to be it: > >> > > When I took a closer look, it appears that PR 172942 was a different crash > > and > > it appears that one was fixed via r264600. > > > > Your problem does not appear to be in the bugs database. (I will commit the > > patch in mid-November anyhow, but creating a PR for this might be useful > > for > > others.) > > > > Btw, I think the attached patch (which includes this change) also fixes a > > problem that caused a crash during mounting, reported via PR 201912. > > (If you`d like to test this one that would be appreciated. It should be > > applied to code not already patched with the one below, since the below > > patch is included in it.) > > > > Thanks for your help with this, rick > > > I'll put your patch on the VM in question. Btw. it has been up for 6 days now > without a crash. > > Before I do that I would like to see that it really addresses PR 201912. > > Do you have any idea how I could provoke that one ? > Not really, I'm afraid. The patch deals with the failure cases in smb_vc_create(), which I think was what caused the crash, given the backtrace in the PR. You can look at smb_vc_create() and see there is a bunch of "goto fail;" cases, but I don't know how to specifically tickle any of these? You could "fake it" by putting a "goto fail;" at line#428, just after the "error = ENOMEM;". This will break smb_vc_create() big time, but I think it will generate the same crash as PR 201912. > Ideally I would like to do the stuff that forces the panic, then apply > the patch and see that the system stays stable despite me doing the > silly moves again. > That would be nice, but so long as I know that the patch doesn't cause a regression, I am comfortable committing it. (This refers to the other 2 changes in the patch. It seems clear that the fix in smbiod2.patch is ok to commit.) Thanks for all your help with this, rick > Greetings > Christian > > -- > Christian Kratzer CK Software GmbH > Email: ck@cksoft.de Wildberger Weg 24/2 > Phone: +49 7032 893 997 - 0 D-71126 Gaeufelden > Fax: +49 7032 893 997 - 9 HRB 245288, Amtsgericht Stuttgart > Mobile: +49 171 1947 843 Geschaeftsfuehrer: Christian Kratzer > Web: http://www.cksoft.de/ > _______________________________________________ > freebsd-stable@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-stable > To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd.org" >