From owner-cvs-all Mon Sep 23 11:26:38 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DE71A37B401; Mon, 23 Sep 2002 11:26:36 -0700 (PDT) Received: from corbulon.video-collage.com (corbulon.video-collage.com [64.35.99.179]) by mx1.FreeBSD.org (Postfix) with ESMTP id E2AB543E6E; Mon, 23 Sep 2002 11:26:35 -0700 (PDT) (envelope-from mi+mx@aldan.algebra.com) Received: from misha.murex.com (250-217.customer.cloud9.net [168.100.250.217]) by corbulon.video-collage.com (8.12.2/8.12.2) with ESMTP id g8NIQWPW036893 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=FAIL); Mon, 23 Sep 2002 14:26:34 -0400 (EDT) (envelope-from mi+mx@aldan.algebra.com) X-Authentication-Warning: corbulon.video-collage.com: Host 250-217.customer.cloud9.net [168.100.250.217] claimed to be misha.murex.com Content-Type: text/plain; charset="koi8-u" From: Mikhail Teterin Organization: Virtual Estates, Inc. To: Stephen McKay , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/cp cp.c Date: Mon, 23 Sep 2002 14:28:06 -0400 User-Agent: KMail/1.4.3 References: <200209221115.g8MBFv00023063@freefall.freebsd.org> In-Reply-To: <200209221115.g8MBFv00023063@freefall.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-Id: <200209231428.06798.mi+mx@aldan.algebra.com> X-Scanned-By: MIMEDefang 2.15 (www dot roaringpenguin dot com slash mimedefang) Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sunday 22 September 2002 07:15 am, Stephen McKay wrote: = mckay 2002/09/22 04:15:57 PDT = = Modified files: = bin/cp cp.c = Log: = cp -p could report success even if a file copy failed. This was = due to the cumulative exit status being overwritten when directory = permissions were being set. This was particularly bad when called = from mv(1) to perform a cross-device move as the original files were = deleted even if the copy failed. It could also report failure -- from changing the timestamps and such, even though the file was copied. It, probably, still should report the problem, but the message the user sees should be more detailed. What about MFC-ing? -mi = Reported by: Slaven Rezic = Patch by: bde = PR: 42789 = = Revision Changes Path = 1.42 +4 -3 src/bin/cp/cp.c -- Как, Вы разве без шпаги пришли? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message