From owner-p4-projects@FreeBSD.ORG  Wed Nov 26 00:26:32 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 7C9C71065676; Wed, 26 Nov 2008 00:26:32 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3F7031065672;
	Wed, 26 Nov 2008 00:26:32 +0000 (UTC)
	(envelope-from prvs=julian=20980669f@elischer.org)
Received: from smtp-outbound.ironport.com (smtp-outbound.ironport.com
	[63.251.108.112])
	by mx1.freebsd.org (Postfix) with ESMTP id 2E5168FC14;
	Wed, 26 Nov 2008 00:26:32 +0000 (UTC)
	(envelope-from prvs=julian=20980669f@elischer.org)
Received: from jelischer-laptop.sfo.ironport.com (HELO
	julian-mac.elischer.org) ([10.251.22.38])
	by smtp-outbound.ironport.com with ESMTP; 25 Nov 2008 16:15:12 -0800
Message-ID: <492C9515.9020703@elischer.org>
Date: Tue, 25 Nov 2008 16:15:17 -0800
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 2.0.0.18 (Macintosh/20081105)
MIME-Version: 1.0
To: Marko Zec <zec@FreeBSD.org>
References: <200811252347.mAPNlvda037095@repoman.freebsd.org>
In-Reply-To: <200811252347.mAPNlvda037095@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 153564 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Nov 2008 00:26:32 -0000

Marko Zec wrote:
> http://perforce.freebsd.org/chv.cgi?CH=153564
> 
> Change 153564 by zec@zec_tpx32 on 2008/11/25 23:47:35
> 
> 	static struct sockaddr key_src should most probably be
> 	virtualized as well (?)
> 

why?

is it ever written to?

> Affected files ...
> 
> .. //depot/projects/vimage-commit2/src/sys/netipsec/keysock.c#14 edit
> .. //depot/projects/vimage-commit2/src/sys/netipsec/vipsec.h#9 edit
> 
> Differences ...
> 
> ==== //depot/projects/vimage-commit2/src/sys/netipsec/keysock.c#14 (text+ko) ====
> 
> @@ -74,10 +74,9 @@
>  #ifdef VIMAGE_GLOBALS
>  static struct key_cb key_cb;
>  struct pfkeystat pfkeystat;
> +static struct sockaddr key_src;
>  #endif
>  
> -static struct sockaddr key_src = { 2, PF_KEY, };
> -
>  static int key_sendup0 __P((struct rawcb *, struct mbuf *, int));
>  
>  /*
> @@ -573,6 +572,9 @@
>  {
>  	INIT_VNET_IPSEC(curvnet);
>  
> +	V_key_src.sa_len = 2;
> +	V_key_src.sa_family = PF_KEY;
> +
>  	bzero((caddr_t)&V_key_cb, sizeof(V_key_cb));
>  	ipsec_init();
>  	key_init();
> 
> ==== //depot/projects/vimage-commit2/src/sys/netipsec/vipsec.h#9 (text+ko) ====
> 
> @@ -106,7 +106,7 @@
>  
>  	struct pfkeystat	_pfkeystat;
>  	struct key_cb		_key_cb;
> -
> +	struct sockaddr		_key_src;
>  	LIST_HEAD(, secpolicy)	_sptree[IPSEC_DIR_MAX];
>  	LIST_HEAD(, secashead)	_sahtree;
>  	LIST_HEAD(, secreg)	_regtree[SADB_SATYPE_MAX + 1];