From owner-svn-src-head@freebsd.org Wed Apr 26 12:10:45 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F124CD5176F; Wed, 26 Apr 2017 12:10:45 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vps1.elischer.org", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id B051221F; Wed, 26 Apr 2017 12:10:45 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from Julian-MBP3.local (124-168-240-29.dyn.iinet.net.au [124.168.240.29]) (authenticated bits=0) by vps1.elischer.org (8.15.2/8.15.2) with ESMTPSA id v3QCATCU041480 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 26 Apr 2017 05:10:34 -0700 (PDT) (envelope-from julian@freebsd.org) Subject: Re: svn commit: r317409 - head/contrib/tcpdump To: Xin LI , rgrimes@freebsd.org References: <201704251907.v3PJ7Mxv062849@pdx.rh.CN85.dnsmgr.net> Cc: Benjamin Kaduk , Gleb Smirnoff , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" From: Julian Elischer Message-ID: Date: Wed, 26 Apr 2017 20:10:24 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Apr 2017 12:10:46 -0000 On 26/4/17 3:29 am, Xin LI wrote: > On Tue, Apr 25, 2017 at 12:07 PM, Rodney W. Grimes > wrote: >> [ Charset UTF-8 unsupported, converting... ] >>> On Tue, Apr 25, 2017 at 1:30 PM, Rodney W. Grimes < >>> freebsd@pdx.rh.cn85.dnsmgr.net> wrote: >>> >>>> [ Charset UTF-8 unsupported, converting... ] >>>>> Author: glebius >>>>> Date: Tue Apr 25 15:56:46 2017 >>>>> New Revision: 317409 >>>>> URL: https://svnweb.freebsd.org/changeset/base/317409 >>>>> >>>>> Log: >>>>> Cherry-pick 5d3c5151c2b885aab36627bafb8539238da27b2d, it fixes use >>>> after free >>>> >>>> Lets not use git hashes as references in commit messages, >>>> it has very little value for someone reading a log of changes >>>> looking for something. There is no promise that it can be >>>> found later (github can go Poof). >>>> >>> On the contrary, a git SHA1 seems like an eminently stable and unique >>> search parameter! >>> I agree that a commit log should inline some summary of the change as well >>> as provide a >>> link to the external source, but I am not worried that a future reader will >>> be unable to find >>> the referenced commit. >> There is no administrative policy in place that says github users shall >> maintain there history. > Anyone who have a copy of the git repository would be able to 'git > show 5d3c5151c2b885aab36627bafb8539238da27b2d' and prove (arguably, > SHA1 is now broken, but it's still better than referencing e.g. a CVS > or SVN revision), and the location of the repository is publicly > known. > >> I had too many indirections to find this change on github: >> commitlog -> google -> wrong article that references this sha1 -> actual commit >> >> I re-iterate lets NOT start to use git hashes in our commit messages. > I don't see any problem with Gleb's commit message, it have referenced > the original commit using the right notion (Git SHA1) and have > included a brief description of what was done at the same time. I see no reason to not add a hash *as secondary data*. Just not primary. Copy the commit message.. > >