Date: Thu, 27 Sep 2012 18:01:06 +0300 From: Mikolaj Golub <trociny@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: Anuranjan Shukla <anshukla@juniper.net>, freebsd-current@freebsd.org, FreeBSD Current <current@freebsd.org> Subject: Re: Proposal for change to kernel linker for fixing a VNET and DPCPU problem. Message-ID: <20120927150105.GC6578@gmail.com> In-Reply-To: <201209251107.02279.jhb@freebsd.org> References: <5F3C03B6-01D0-42DE-BE9E-323DBDC90C8E@neville-neil.com> <20120921092235.GC66984@gmail.com> <505C9C58.3060006@freebsd.org> <201209251107.02279.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Sep 25, 2012 at 11:07:02AM -0400, John Baldwin wrote: > On Friday, September 21, 2012 12:56:56 pm Julian Elischer wrote: > > On 9/21/12 2:22 AM, Mikolaj Golub wrote: > > > http://people.freebsd.org/~trociny/link_elf.c.pcpu_vnet.patch > > > > > > The fix is to make the linker on a module load recognize "external" > > > VNET/DPCPU variables defined in the previously loaded modules and > > > relocate them accordingly. For this set_pcpu_list and set_vnet_list > > > are used, where the addresses of modules 'set_pcpu' and 'set_vnet' > > > linker sets are stored in. > > > > it makes sense to me, but I really am not a linker person.. > > I think it woul be good to get Doug Rabson to weigh in on it, and > > maybe john Baldwin.. > > > > moving to -current as it's not a "net" issue really.. > > I think the proposed patch is ok. Thanks! Committed as r240997. -- Mikolaj Golub
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120927150105.GC6578>