Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 3 Mar 2003 19:39:23 -0500 (EST)
From:      Jeff Roberson <jroberson@chesapeake.net>
To:        Alfred Perlstein <bright@mu.org>
Cc:        Jeff Roberson <jeff@FreeBSD.org>, <src-committers@FreeBSD.org>, <cvs-src@FreeBSD.org>, <cvs-all@FreeBSD.org>
Subject:   Re: cvs commit: src/sys/kern vfs_default.c
Message-ID:  <20030303193715.N72102-100000@mail.chesapeake.net>
In-Reply-To: <20030304003400.GG43089@elvis.mu.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 3 Mar 2003, Alfred Perlstein wrote:

> >
> >   Modified files:
> >     sys/kern             vfs_default.c
> >   Log:
> >    - Correct the wchan in vop_stdfsync()
> >
> >   This is almost what bde asked for.  There is some desire to have per fs wchans
> >   still but that is difficult giving the current arrangement of the code.
>
> not safe, but the general idea...
>
> char wchanstkbuf[7];
> char *p = wchanstkbuf;
>
> sprintf(p, "%ssync", vp->v_type);
>

Yeah, I was considering something along these lines.  Unfortunately you're
likely to only get 2 characters of the filesystem type if you used "sync"
for the rest.  This yields a potentially more effecient and safe
implementation:

char wchanbuf[7] = "  sync";
wchanbuf[0] = vp->v_type[0];
wchanbuf[1] = vp->v_type[1];

Looks good no?

Maybe I'll check that in.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-src" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030303193715.N72102-100000>