From owner-svn-src-all@FreeBSD.ORG Mon Apr 6 00:22:50 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5B8F310657C0; Mon, 6 Apr 2009 00:22:50 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 4747D8FC15; Mon, 6 Apr 2009 00:22:50 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n360MoCa039511; Mon, 6 Apr 2009 00:22:50 GMT (envelope-from thompsa@svn.freebsd.org) Received: (from thompsa@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n360MnJr039488; Mon, 6 Apr 2009 00:22:49 GMT (envelope-from thompsa@svn.freebsd.org) Message-Id: <200904060022.n360MnJr039488@svn.freebsd.org> From: Andrew Thompson Date: Mon, 6 Apr 2009 00:22:49 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r190754 - in head/sys/dev/usb: . controller X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Apr 2009 00:22:50 -0000 Author: thompsa Date: Mon Apr 6 00:22:49 2009 New Revision: 190754 URL: http://svn.freebsd.org/changeset/base/190754 Log: Provide a better commit log for r190735, forced by making a whitespace change. Refactor how we interface with the root HUB. This is achieved by making a direct call from usb2_do_request to the host controller for root hub requests, this call will perform the controller specific register read/writes and return the error code. This cuts out a lot of code in the host controller files and saves one thread per USB bus. Submitted by: Hans Petter Selasky Modified: head/sys/dev/usb/controller/at91dci.c head/sys/dev/usb/controller/at91dci.h head/sys/dev/usb/controller/atmegadci.c head/sys/dev/usb/controller/atmegadci.h head/sys/dev/usb/controller/ehci.c head/sys/dev/usb/controller/ehci.h head/sys/dev/usb/controller/musb_otg.c head/sys/dev/usb/controller/musb_otg.h head/sys/dev/usb/controller/ohci.c head/sys/dev/usb/controller/ohci.h head/sys/dev/usb/controller/uhci.c head/sys/dev/usb/controller/uhci.h head/sys/dev/usb/controller/usb_controller.c head/sys/dev/usb/controller/uss820dci.c head/sys/dev/usb/usb_bus.h head/sys/dev/usb/usb_controller.h head/sys/dev/usb/usb_core.h head/sys/dev/usb/usb_device.c head/sys/dev/usb/usb_hub.c head/sys/dev/usb/usb_hub.h head/sys/dev/usb/usb_request.c head/sys/dev/usb/usb_transfer.c Modified: head/sys/dev/usb/controller/at91dci.c ============================================================================== --- head/sys/dev/usb/controller/at91dci.c Sun Apr 5 23:25:06 2009 (r190753) +++ head/sys/dev/usb/controller/at91dci.c Mon Apr 6 00:22:49 2009 (r190754) @@ -38,7 +38,7 @@ __FBSDID("$FreeBSD$"); /* * NOTE: The "fifo_bank" is not reset in hardware when the endpoint is - * reset ! + * reset. * * NOTE: When the chip detects BUS-reset it will also reset the * endpoints, Function-address and more. Modified: head/sys/dev/usb/controller/at91dci.h ============================================================================== --- head/sys/dev/usb/controller/at91dci.h Sun Apr 5 23:25:06 2009 (r190753) +++ head/sys/dev/usb/controller/at91dci.h Mon Apr 6 00:22:49 2009 (r190754) @@ -27,8 +27,8 @@ */ /* - * USB Device Port (UDP) register definition, based on - * "AT91RM9200.h" provided by ATMEL. + * USB Device Port (UDP) register definition, based on "AT91RM9200.h" provided + * by ATMEL. */ #ifndef _AT9100_DCI_H_ Modified: head/sys/dev/usb/controller/atmegadci.c ============================================================================== --- head/sys/dev/usb/controller/atmegadci.c Sun Apr 5 23:25:06 2009 (r190753) +++ head/sys/dev/usb/controller/atmegadci.c Mon Apr 6 00:22:49 2009 (r190754) @@ -27,9 +27,8 @@ __FBSDID("$FreeBSD$"); */ /* - * This file contains the driver for the ATMEGA series USB OTG - * Controller. This driver currently only supports the DCI mode of the - * USB hardware. + * This file contains the driver for the ATMEGA series USB OTG Controller. This + * driver currently only supports the DCI mode of the USB hardware. */ /* Modified: head/sys/dev/usb/controller/atmegadci.h ============================================================================== --- head/sys/dev/usb/controller/atmegadci.h Sun Apr 5 23:25:06 2009 (r190753) +++ head/sys/dev/usb/controller/atmegadci.h Mon Apr 6 00:22:49 2009 (r190754) @@ -25,8 +25,8 @@ */ /* - * USB Device Port register definitions, copied from ATMEGA - * documentation provided by ATMEL. + * USB Device Port register definitions, copied from ATMEGA documentation + * provided by ATMEL. */ #ifndef _ATMEGADCI_H_ Modified: head/sys/dev/usb/controller/ehci.c ============================================================================== --- head/sys/dev/usb/controller/ehci.c Sun Apr 5 23:25:06 2009 (r190753) +++ head/sys/dev/usb/controller/ehci.c Mon Apr 6 00:22:49 2009 (r190754) @@ -39,7 +39,7 @@ */ /* - * TODO: + * TODO: * 1) command failures are not recovered correctly */ Modified: head/sys/dev/usb/controller/ehci.h ============================================================================== --- head/sys/dev/usb/controller/ehci.h Sun Apr 5 23:25:06 2009 (r190753) +++ head/sys/dev/usb/controller/ehci.h Mon Apr 6 00:22:49 2009 (r190754) @@ -40,7 +40,7 @@ #define EHCI_MAX_DEVICES MIN(USB_MAX_DEVICES, 128) -/* PCI config registers */ +/* PCI config registers */ #define PCI_CBMEM 0x10 /* configuration base MEM */ #define PCI_INTERFACE_EHCI 0x20 #define PCI_USBREV 0x60 /* RO USB protocol revision */ Modified: head/sys/dev/usb/controller/musb_otg.c ============================================================================== --- head/sys/dev/usb/controller/musb_otg.c Sun Apr 5 23:25:06 2009 (r190753) +++ head/sys/dev/usb/controller/musb_otg.c Mon Apr 6 00:22:49 2009 (r190754) @@ -25,8 +25,8 @@ */ /* - * Thanks to Mentor Graphics for providing a reference driver for this - * USB chip at their homepage. + * Thanks to Mentor Graphics for providing a reference driver for this USB chip + * at their homepage. */ /* Modified: head/sys/dev/usb/controller/musb_otg.h ============================================================================== --- head/sys/dev/usb/controller/musb_otg.h Sun Apr 5 23:25:06 2009 (r190753) +++ head/sys/dev/usb/controller/musb_otg.h Mon Apr 6 00:22:49 2009 (r190754) @@ -25,8 +25,8 @@ */ /* - * This header file defines the registers of the Mentor Graphics - * USB OnTheGo Inventra chip. + * This header file defines the registers of the Mentor Graphics USB OnTheGo + * Inventra chip. */ #ifndef _MUSB2_OTG_H_ Modified: head/sys/dev/usb/controller/ohci.c ============================================================================== --- head/sys/dev/usb/controller/ohci.c Sun Apr 5 23:25:06 2009 (r190753) +++ head/sys/dev/usb/controller/ohci.c Mon Apr 6 00:22:49 2009 (r190754) @@ -32,7 +32,7 @@ __FBSDID("$FreeBSD$"); * USB Open Host Controller driver. * * OHCI spec: http://www.compaq.com/productinfo/development/openhci.html - * USB spec: http://www.usb.org/developers/docs/usbspec.zip + * USB spec: http://www.usb.org/developers/docs/usbspec.zip */ #include Modified: head/sys/dev/usb/controller/ohci.h ============================================================================== --- head/sys/dev/usb/controller/ohci.h Sun Apr 5 23:25:06 2009 (r190753) +++ head/sys/dev/usb/controller/ohci.h Mon Apr 6 00:22:49 2009 (r190754) @@ -41,7 +41,7 @@ #define OHCI_MAX_DEVICES MIN(USB_MAX_DEVICES, 128) -/* PCI config registers */ +/* PCI config registers */ #define PCI_CBMEM 0x10 /* configuration base memory */ #define PCI_INTERFACE_OHCI 0x10 Modified: head/sys/dev/usb/controller/uhci.c ============================================================================== --- head/sys/dev/usb/controller/uhci.c Sun Apr 5 23:25:06 2009 (r190753) +++ head/sys/dev/usb/controller/uhci.c Mon Apr 6 00:22:49 2009 (r190754) @@ -33,7 +33,7 @@ __FBSDID("$FreeBSD$"); * Handles e.g. PIIX3 and PIIX4. * * UHCI spec: http://developer.intel.com/design/USB/UHCI11D.htm - * USB spec: http://www.usb.org/developers/docs/usbspec.zip + * USB spec: http://www.usb.org/developers/docs/usbspec.zip * PIIXn spec: ftp://download.intel.com/design/intarch/datashts/29055002.pdf * ftp://download.intel.com/design/intarch/datashts/29056201.pdf */ Modified: head/sys/dev/usb/controller/uhci.h ============================================================================== --- head/sys/dev/usb/controller/uhci.h Sun Apr 5 23:25:06 2009 (r190753) +++ head/sys/dev/usb/controller/uhci.h Mon Apr 6 00:22:49 2009 (r190754) @@ -41,7 +41,7 @@ #define UHCI_MAX_DEVICES MIN(USB_MAX_DEVICES, 128) -/* PCI config registers */ +/* PCI config registers */ #define PCI_USBREV 0x60 /* USB protocol revision */ #define PCI_USB_REV_MASK 0xff #define PCI_USB_REV_PRE_1_0 0x00 Modified: head/sys/dev/usb/controller/usb_controller.c ============================================================================== --- head/sys/dev/usb/controller/usb_controller.c Sun Apr 5 23:25:06 2009 (r190753) +++ head/sys/dev/usb/controller/usb_controller.c Mon Apr 6 00:22:49 2009 (r190754) @@ -41,7 +41,7 @@ #include #include -/* function prototypes */ +/* function prototypes */ static device_probe_t usb2_probe; static device_attach_t usb2_attach; Modified: head/sys/dev/usb/controller/uss820dci.c ============================================================================== --- head/sys/dev/usb/controller/uss820dci.c Sun Apr 5 23:25:06 2009 (r190753) +++ head/sys/dev/usb/controller/uss820dci.c Mon Apr 6 00:22:49 2009 (r190754) @@ -29,7 +29,7 @@ * This file contains the driver for the USS820 series USB Device * Controller * - * NOTE: The datasheet does not document everything! + * NOTE: The datasheet does not document everything. */ #include Modified: head/sys/dev/usb/usb_bus.h ============================================================================== --- head/sys/dev/usb/usb_bus.h Sun Apr 5 23:25:06 2009 (r190753) +++ head/sys/dev/usb/usb_bus.h Mon Apr 6 00:22:49 2009 (r190754) @@ -28,8 +28,8 @@ #define _USB2_BUS_H_ /* - * The following structure defines the USB explore message sent to the - * USB explore process. + * The following structure defines the USB explore message sent to the USB + * explore process. */ struct usb2_bus_msg { Modified: head/sys/dev/usb/usb_controller.h ============================================================================== --- head/sys/dev/usb/usb_controller.h Sun Apr 5 23:25:06 2009 (r190753) +++ head/sys/dev/usb/usb_controller.h Mon Apr 6 00:22:49 2009 (r190754) @@ -31,7 +31,7 @@ #define USB_BUS_DMA_TAG_MAX 8 -/* structure prototypes */ +/* structure prototypes */ struct usb2_bus; struct usb2_page; Modified: head/sys/dev/usb/usb_core.h ============================================================================== --- head/sys/dev/usb/usb_core.h Sun Apr 5 23:25:06 2009 (r190753) +++ head/sys/dev/usb/usb_core.h Mon Apr 6 00:22:49 2009 (r190754) @@ -25,8 +25,7 @@ */ /* - * Including this file is mandatory for all USB related c-files in the - * kernel. + * Including this file is mandatory for all USB related c-files in the kernel. */ #ifndef _USB2_CORE_H_ Modified: head/sys/dev/usb/usb_device.c ============================================================================== --- head/sys/dev/usb/usb_device.c Sun Apr 5 23:25:06 2009 (r190753) +++ head/sys/dev/usb/usb_device.c Mon Apr 6 00:22:49 2009 (r190754) @@ -55,7 +55,7 @@ #include #include -/* function prototypes */ +/* function prototypes */ static void usb2_init_pipe(struct usb2_device *, uint8_t, struct usb2_endpoint_descriptor *, struct usb2_pipe *); Modified: head/sys/dev/usb/usb_hub.c ============================================================================== --- head/sys/dev/usb/usb_hub.c Sun Apr 5 23:25:06 2009 (r190753) +++ head/sys/dev/usb/usb_hub.c Mon Apr 6 00:22:49 2009 (r190754) @@ -27,7 +27,7 @@ */ /* - * USB spec: http://www.usb.org/developers/docs/usbspec.zip + * USB spec: http://www.usb.org/developers/docs/usbspec.zip */ #include Modified: head/sys/dev/usb/usb_hub.h ============================================================================== --- head/sys/dev/usb/usb_hub.h Sun Apr 5 23:25:06 2009 (r190753) +++ head/sys/dev/usb/usb_hub.h Mon Apr 6 00:22:49 2009 (r190754) @@ -28,7 +28,7 @@ #define _USB2_HUB_H_ /* - * The following structure defines an USB port. + * The following structure defines an USB port. */ struct usb2_port { uint8_t restartcnt; Modified: head/sys/dev/usb/usb_request.c ============================================================================== --- head/sys/dev/usb/usb_request.c Sun Apr 5 23:25:06 2009 (r190753) +++ head/sys/dev/usb/usb_request.c Mon Apr 6 00:22:49 2009 (r190754) @@ -24,7 +24,7 @@ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. - */ + */ #include #include Modified: head/sys/dev/usb/usb_transfer.c ============================================================================== --- head/sys/dev/usb/usb_transfer.c Sun Apr 5 23:25:06 2009 (r190753) +++ head/sys/dev/usb/usb_transfer.c Mon Apr 6 00:22:49 2009 (r190754) @@ -22,7 +22,7 @@ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. - */ + */ #include #include