From owner-p4-projects@FreeBSD.ORG  Mon Aug  8 23:48:30 2005
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 2185F16A421; Mon,  8 Aug 2005 23:48:30 +0000 (GMT)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EFF3716A41F
	for <perforce@freebsd.org>; Mon,  8 Aug 2005 23:48:29 +0000 (GMT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B8DC843D45
	for <perforce@freebsd.org>; Mon,  8 Aug 2005 23:48:29 +0000 (GMT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j78NmTlx062423
	for <perforce@freebsd.org>; Mon, 8 Aug 2005 23:48:29 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j78NmT44062420
	for perforce@freebsd.org; Mon, 8 Aug 2005 23:48:29 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Date: Mon, 8 Aug 2005 23:48:29 GMT
Message-Id: <200508082348.j78NmT44062420@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 81692 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Aug 2005 23:48:31 -0000

http://perforce.freebsd.org/chv.cgi?CH=81692

Change 81692 by rwatson@rwatson_peppercorn on 2005/08/08 23:47:53

	Several XXX's that don't need to be.

Affected files ...

.. //depot/projects/netsmp/src/sys/net/if.c#11 edit

Differences ...

==== //depot/projects/netsmp/src/sys/net/if.c#11 (text+ko) ====

@@ -1279,9 +1279,8 @@
 		if (error)
 			return (error);
 		/*
-		 * XXXRW: Currently, no driver owned flags pass the
-		 * IFF_CANTCHANGE check, so we don't need special handling
-		 * here yet.
+		 * Currently, no driver owned flags pass the IFF_CANTCHANGE
+		 * check, so we don't need special handling here yet.
 		 */
 		new_flags = (ifr->ifr_flags & 0xffff) |
 		    (ifr->ifr_flagshigh << 16);
@@ -1625,7 +1624,7 @@
  * The "pflag" argument can specify a permanent mode flag,
  * such as IFF_PPROMISC for promiscuous mode; should be 0 if none.
  *
- * XXXRW: Only to be used on stack-owned flags, not driver-owned flags.
+ * Only to be used on stack-owned flags, not driver-owned flags.
  */
 static int
 if_setflag(struct ifnet *ifp, int flag, int pflag, int *refcount, int onswitch)
@@ -2273,10 +2272,6 @@
 		ifp->if_obytes += m->m_pkthdr.len + adjust;
 		if (m->m_flags & (M_BCAST|M_MCAST))
 			ifp->if_omcasts++;
-		/*
-		 * XXXRW: Technically, we'd like the driver to do this to
-		 * avoid races.
-		 */
 		active = ifp->if_drv_flags & IFF_DRV_OACTIVE;
 	}
 	_IF_ENQUEUE(ifq, m);