From owner-svn-src-all@freebsd.org Sun Mar 17 17:59:06 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E49051545187; Sun, 17 Mar 2019 17:59:05 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-it1-x130.google.com (mail-it1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 770B889BE0; Sun, 17 Mar 2019 17:59:05 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-it1-x130.google.com with SMTP id f186so14777079ita.0; Sun, 17 Mar 2019 10:59:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=78ioTPPr7qLPyAmHW45dMpxh3qXdXujQ+/5xkwJRcm4=; b=lL50oau6A9/T2c5EY0ijJo1mof/jw+Pap+QOC710dqw3wlWtzT5yN5U2ALboiAyjfs kVeymyEI1oCY9/SgpnY6SrVlvhKlYfBkqI5OTVbC3uk334Cd0tyN43nfxYPZtFusm5Cl 0soqF2eimk1FV7dC0T9GkstGmkdJAkFc9KXSVHQJV0rmHACbxSFrhRhQQhuMb8nML3cT P09XKnjTaWCcPB/fAWjvtjeyLc7Bf1j00Ns1BDWlBJHue9AX1RFdbNbZAxw5BwlzpVXo THnf3H7wlgEAyIPivJTqbjwvrYw4w4ZgBY4sebBIx4x+qOastuPuWgY0n1lL8it4oE2X 23vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=78ioTPPr7qLPyAmHW45dMpxh3qXdXujQ+/5xkwJRcm4=; b=eqZM3O6L5iZ2oMiLl7NoXlHlBbzBeK5BMVZ2rMcNRx9ZsYdxTPf3+Nq69fR2p/5tPV 8rSyasBl8oQR1o4SGHp6j4560eqM5eFfNWAEd0tfIFnTnyBOTqwkLWeCj5CFfWfwoeRb nsS/l54YcqQxXZri8tYLSWqIgivDC4aAX1H7UmwvJgW/+wdAX4/0n40p7u8Xz3r5cWBp 0Mxa2wskn8agUCi+bP7BZVHnXF9AmAQQKcHJqVaDm3E0sSiplOs7VMJd7zByfCS68xdh H8yBeEQQydahMMRV+R8Qdpw+OPgvG5EnTg5BFgNtQF1ilRVCpitdi57e9CVboQ6ncQ6D /sWQ== X-Gm-Message-State: APjAAAWuv/V9NZXXMtSM+YzxSHNWpLu8wVyvOwoOxzon1/oo1U1X/yLO OWDAZp1csaBdKnm/+imiEOY8jbtx X-Google-Smtp-Source: APXvYqzK3JkSiu32zYlGfsEVV5OUWcTsMGQAayssUMnofLbscOYzBr0T13ujdwWED/KrfPd+74oLtw== X-Received: by 2002:a02:700f:: with SMTP id f15mr6057011jac.139.1552845544295; Sun, 17 Mar 2019 10:59:04 -0700 (PDT) Received: from raichu (toroon0560w-lp140-01-69-159-36-102.dsl.bell.ca. [69.159.36.102]) by smtp.gmail.com with ESMTPSA id g186sm4191937iof.41.2019.03.17.10.59.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 17 Mar 2019 10:59:03 -0700 (PDT) Sender: Mark Johnston Date: Sun, 17 Mar 2019 13:58:59 -0400 From: Mark Johnston To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r345244 - head/sys/ufs/ufs Message-ID: <20190317175858.GA16331@raichu> References: <201903171734.x2HHY6FM004905@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201903171734.x2HHY6FM004905@repo.freebsd.org> User-Agent: Mutt/1.11.3 (2019-02-01) X-Rspamd-Queue-Id: 770B889BE0 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.975,0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Mar 2019 17:59:06 -0000 On Sun, Mar 17, 2019 at 05:34:06PM +0000, Mark Johnston wrote: > Author: markj > Date: Sun Mar 17 17:34:06 2019 > New Revision: 345244 > URL: https://svnweb.freebsd.org/changeset/base/345244 > > Log: > Optimize lseek(SEEK_DATA) on UFS. > > The old implementation, at the VFS layer, would map the entire range of > logical blocks between the starting offset and the first data block > following that offset. With large sparse files this is very > inefficient. The VFS currently doesn't provide an interface to improve > upon the current implementation in a generic way. > > Add ufs_bmap_seekdata(), which uses the obvious algorithm of scanning > indirect blocks to look for data blocks. Use it instead of > vn_bmap_seekhole() to implement SEEK_DATA. > > Reviewed by: kib, mckusick > MFC after: 2 weeks > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D19598 This should have been: https://reviews.freebsd.org/D19599