From owner-dev-commits-src-main@freebsd.org Tue Apr 20 16:44:38 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BBD6C5DF0A7 for ; Tue, 20 Apr 2021 16:44:38 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FPqKL4kmHz3DQC for ; Tue, 20 Apr 2021 16:44:38 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72e.google.com with SMTP id z2so2991913qkb.9 for ; Tue, 20 Apr 2021 09:44:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5/SHM99+BddDQYVEyl19MxIwMTYeUMC3oX+GURfGMYE=; b=me9QGcPgT32CAOXGJjmptK77AUj7K3+n2Y4Gg/6vSIOH8iOwveTaIKYgzyhT/d2upN hwRgNm2rRZrDteW38r+eBhXxt2DWlNZoQHafp84drB0Sf8TUntm0wP91WMXWlWGDMVhp vb74m0CyNB5uZJ59SHAs4qk8YWWakAdxA4ouCsqF2uGrin84F5qKE499WCOtrku+fou8 NuN8yFKr7nrpFZUc8oMEcgi4uMtV9OZWJ8mlu5bMY8LDk0Ddk/amgWUrx0q15fFR/Ogu BOIMqfnimNHOaewVaSUg4Dkgy/vV6mIcVmv5ME51mVc+eEXlOOG6s+PphvU5Q35lZkXT cadA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5/SHM99+BddDQYVEyl19MxIwMTYeUMC3oX+GURfGMYE=; b=UzioVdjuEfMImJwhxdJKylGMDjqqdAtPpxa8P1jVXg/Gk5B4JPsqMWH553sPY7uEpB g+Kdl+X/Gyq47I7prEtErhhx6xmnbMsE+ri4MjDynHOPEZ3ALgcJIuBVbI4v6/XKxSCh p37RT1PVlVmXEgzY49SZLSmtEad+e1HtXUi+oyynNepb0/7meZIUlCXw/h/7IEBO3fjf PlkEIcwJ0OVckZpvxSgvwL0ZdfEgTdzFrx/Bn7TmBGhA+Htr9vSg797+CWgDwOQbcKSS qBJzwAgTJuvEBytyrI8lIhp3sOv2SnKWm8kiLi3fu7hUGbjxnB8MamyEu7YJSqtfd+wc V8WQ== X-Gm-Message-State: AOAM533FRGp1VPoSUWKX5LhV5YWtNUX5HteQcPdx/SmgQ3i4zo/fr+LH /p3nVxZgwi1MO7vUe4HtnWUKp6ayc4JVcxaDN1aPmteHuvYJSw== X-Google-Smtp-Source: ABdhPJzgBRZhabBcYa4op9eaUL13/su08MVSO1V6aNnIqmqjMbWdYIJltEhCyUqjVDjSl9m2ObShI8n83NzTHw1EnCk= X-Received: by 2002:a37:6492:: with SMTP id y140mr9752605qkb.89.1618937077033; Tue, 20 Apr 2021 09:44:37 -0700 (PDT) MIME-Version: 1.0 References: <202104201609.13KG9w0e071568@gndrsh.dnsmgr.net> <782d3c7b-fb30-d013-0426-692cc1ead645@FreeBSD.org> In-Reply-To: <782d3c7b-fb30-d013-0426-692cc1ead645@FreeBSD.org> From: Warner Losh Date: Tue, 20 Apr 2021 10:44:26 -0600 Message-ID: Subject: Re: git: 686cf5468c4a - main - flex: Regen bootstrap files To: Jung-uk Kim Cc: "Rodney W. Grimes" , src-committers , "" , dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4FPqKL4kmHz3DQC X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Apr 2021 16:44:38 -0000 On Tue, Apr 20, 2021 at 10:24 AM Jung-uk Kim wrote: > On 21. 4. 20., Rodney W. Grimes wrote: > >> On 21. 4. 20., Rodney W. Grimes wrote: > >>>> The branch main has been updated by jkim: > >>>> > >>>> URL: > https://cgit.FreeBSD.org/src/commit/?id=686cf5468c4a85c2a6385cdbab2383900876a41d > >>>> > >>>> commit 686cf5468c4a85c2a6385cdbab2383900876a41d > >>>> Author: Jung-uk Kim > >>>> AuthorDate: 2021-04-19 18:20:51 +0000 > >>>> Commit: Jung-uk Kim > >>>> CommitDate: 2021-04-19 18:20:51 +0000 > >>>> > >>>> flex: Regen bootstrap files > >>>> > >>>> This also partially reverts r326025 (8a16b7a18f5d). I do not see > any > >>>> point of adding SPDX tag in generated file. > >>> > >>> The SPDX identifies the copyright that follows it, so please put this > back. > >> > >> It is a generated file. If you really think it is necessary, you need > >> to patch its source, i.e., contrib/flex/src/parse.y, and regen the file. > > > > Just because it is a generated file does not change the fact that > > its contents are copyrighted. Leaving the copyright out at best > > defaults to Bern convention, so the fact of the mater is the contents > > is copyrighted, and it is best to explicitly state that it is. > > Of course, it is copyrighted. My point was parse.y should have been > patched, not the generated file, if necessary. > Yes. It was a mistake to put it into the generated file. > >> However, I don't see much sense in automatically adding BSD license in > >> every generated file in the first place. In fact, I think it should not > >> appear on generated file at all. It may say something along the line of > >> "generated by flex" instead but IANAL. > > > > Well, someone before you did see since in it, and hence put that SPDX in > it. > > Let me put it in another way. Do we really want to tag contrib code? > I tend to agree. I tend to agree because the SPDX tags are generally only looked at in the source tree by existing tools. The generated code won't be looked at typically. We should work to get this upstream, imho. By itself, the SPDX tag is just information. There's no legal requirement in copyright law to have it. Current project policy states they are just informative, though there's some desire to have a good framework to allow code with just a copyright and a SDPX tag into the tree, so long as that framework can be used to know what the license is for any file in a clear and unambiguous way. Warner