From owner-cvs-src@FreeBSD.ORG Wed Nov 1 21:31:58 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C017116A403 for ; Wed, 1 Nov 2006 21:31:58 +0000 (UTC) (envelope-from garyj@jennejohn.org) Received: from mail08b.verio.de (mail08b.verio.de [213.198.55.74]) by mx1.FreeBSD.org (Postfix) with SMTP id 9ABF543D77 for ; Wed, 1 Nov 2006 21:31:56 +0000 (GMT) (envelope-from garyj@jennejohn.org) Received: from mx26.stngva01.us.mxservers.net (204.202.242.40) by mail08b.verio.de (RS ver 1.0.95vs) with SMTP id 3-053376713; Wed, 1 Nov 2006 22:31:54 +0100 (CET) Received: from www.jennejohn.org [213.198.5.174] (EHLO peedub.jennejohn.org) by mx26.stngva01.us.mxservers.net (mxl_mta-1.3.8-10p4) with ESMTP id 94219454.6874.348.mx26.stngva01.us.mxservers.net; Wed, 01 Nov 2006 16:31:53 -0500 (EST) Received: from jennejohn.org (localhost [127.0.0.1]) by peedub.jennejohn.org (8.13.8/8.11.6) with ESMTP id kA1LVmiJ000532; Wed, 1 Nov 2006 22:31:48 +0100 (CET) (envelope-from garyj@jennejohn.org) Message-Id: <200611012131.kA1LVmiJ000532@peedub.jennejohn.org> X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.0.4 To: Giorgos Keramidas In-Reply-To: Message from Giorgos Keramidas of "Wed, 01 Nov 2006 22:19:41 +0200." <20061101201941.GC4417@kobe.laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 01 Nov 2006 22:31:48 +0100 From: Gary Jennejohn X-Spam: [F=0.0238327787; heur=0.500(-19800); stat=0.023; spamtraq-heur=0.500(2006110106)] X-MAIL-FROM: X-SOURCE-IP: [213.198.5.174] X-Loop-Detect: 1 X-DistLoop-Detect: 1 Cc: cvs-src@freebsd.org, Martin Blapp , Tor Egge , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_conf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Nov 2006 21:31:58 -0000 Giorgos Keramidas writes: > On 2006-10-19 02:49, Giorgos Keramidas wrote: > > Maybe it's not related, but all xterm's seem unkillable and blocked > > forever in "devdrn" here, in a build from 2006.10.18.15.56.11. > > > > An earlier sync from 2006.10.13.12.45.54 didn't exhibit this behavior, > > so I guess there's something mildly buggy with this change? > > I still have to use the following local diff to get "killable" xterm > processes: > > % diff -r a61844fa2f23 sys/kern/kern_conf.c > % --- a/sys/kern/kern_conf.c Wed Nov 01 21:49:16 2006 +0200 > % +++ b/sys/kern/kern_conf.c Wed Nov 01 02:33:08 2006 +0200 > % @@ -676,7 +676,6 @@ destroy_devl(struct cdev *dev) > % dev->si_flags &= ~SI_CLONELIST; > % } > % > % - dev->si_refcount++; /* Avoid race with dev_rel() */ > % csw = dev->si_devsw; > % dev->si_devsw = NULL; /* already NULL for SI_ALIAS */ > % while (csw != NULL && csw->d_purge != NULL && dev->si_threadcount) > { > % @@ -686,10 +685,6 @@ destroy_devl(struct cdev *dev) > % printf("Still %lu threads in %s\n", > % dev->si_threadcount, devtoname(dev)); > % } > % - while (dev->si_threadcount != 0) { > % - /* Use unique dummy wait ident */ > % - msleep(&csw, &devmtx, PRIBIO, "devdrn", hz / 10); > % - } > % > % dev->si_drv1 = 0; > % dev->si_drv2 = 0; > % @@ -704,7 +699,6 @@ destroy_devl(struct cdev *dev) > % fini_cdevsw(csw); > % } > % dev->si_flags &= ~SI_ALIAS; > % - dev->si_refcount--; /* Avoid race with dev_rel() */ > % > % if (dev->si_refcount > 0) { > % LIST_INSERT_HEAD(&dead_cdevsw.d_devs, dev, si_list); > > If it is related, at all, I am using `kern.pts.enable=1' here, and a > slightly modified GENERIC kernel config. The differences from GENERIC > are mostly removed SCSI devices and added options for the PF firewall, > but I can send a diff if needed. > Setting kern.pts.enable to 0 definitley makes a difference. xterm and mrxvt exit as one would expect. With it set to 1 I was also seeing the same problem you are. Looks like this change doesn't play nice with pts. > Has this been fixed in HEAD, in a way that I missed while looking at the > recent changes? > No, the problem still exists in a kernel which I just made from sources cvsup'd not long ago. Of course, there is a time lag between commits and updating of the mirrors. --- Gary Jennejohn / garyjATjennejohnDOTorg gjATfreebsdDOTorg garyjATdenxDOTde