From owner-freebsd-current@FreeBSD.ORG Mon Jul 14 15:45:45 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8A41C37B409 for ; Mon, 14 Jul 2003 15:45:45 -0700 (PDT) Received: from kientzle.com (h-66-166-149-50.SNVACAID.covad.net [66.166.149.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id E8B8043FA3 for ; Mon, 14 Jul 2003 15:45:44 -0700 (PDT) (envelope-from kientzle@acm.org) Received: from acm.org (ugly.x.kientzle.com [66.166.149.53]) by kientzle.com (8.12.9/8.12.9) with ESMTP id h6EMjigY029619; Mon, 14 Jul 2003 15:45:44 -0700 (PDT) (envelope-from kientzle@acm.org) Message-ID: <3F133341.5060708@acm.org> Date: Mon, 14 Jul 2003 15:48:33 -0700 From: Tim Kientzle User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.0.1) Gecko/20021005 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Gordon Tetlow References: <20030713214715.H15811@root.org> <20030714004042.A38507@hub.freebsd.org> <20030714160952.GD12996@roark.gnf.org> <3F130805.3060900@acm.org> <20030714194815.GJ12996@roark.gnf.org> <3F132B65.1040506@acm.org> <20030714221937.GL12996@roark.gnf.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: current@freebsd.org cc: Nate Lawson Subject: Re: Overdone rescue cleaning as part of buildworld? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: kientzle@acm.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jul 2003 22:45:46 -0000 Gordon Tetlow wrote: > Attached is the patch. It basically makes CRUNCH_PROGS into a per > directory item and then only does a make obj on the per program > directory. Hmmm.... I do have a philosophical quibble with your approach: My original intent for this Makefile was that the top part was rescue-specific and the bottom part would be sufficiently generic to be used in other crunchgen-based projects. Your patches embed a certain amount of /rescue-specific knowledge into the generic portion of the Makefile. For example, > + cd $(.CURDIR)/../../${D}/${P} makes a prett strong assumption about the relative locations of the crunchgen-using source directory and its components. The advantage of your approach is that you are making the subdirectory handling very tight. Essentially, you are listing exactly the subdirectories to be handled, where my approach is a bit sloppier. The advantage of my approach is that it is less tied to the particulars of "building /rescue as part of the FreeBSD source code." But, this is only a philosophical objection, and no doubt others will see it differently. As you seem willing to be responsible for this code, you should do it in a way that makes you comfortable. In short, go for it. Tim