From owner-freebsd-ports@FreeBSD.ORG  Sun Feb 18 22:11:12 2007
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: ports@freebsd.org
Delivered-To: freebsd-ports@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 9CF8C16A401
	for <ports@freebsd.org>; Sun, 18 Feb 2007 22:11:12 +0000 (UTC)
	(envelope-from sean@mcneil.com)
Received: from mail.mcneil.com (mcneil.com [24.199.45.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 7827F13C4A3
	for <ports@freebsd.org>; Sun, 18 Feb 2007 22:11:12 +0000 (UTC)
	(envelope-from sean@mcneil.com)
Received: from localhost (localhost.mcneil.com [127.0.0.1])
	by mail.mcneil.com (Postfix) with ESMTP id 1D825F1BFC
	for <ports@freebsd.org>; Sun, 18 Feb 2007 13:52:46 -0800 (PST)
X-Virus-Scanned: amavisd-new at mcneil.com
Received: from mail.mcneil.com ([127.0.0.1])
	by localhost (mcneil.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 1D7Cv1pgJDBQ for <ports@freebsd.org>;
	Sun, 18 Feb 2007 13:52:43 -0800 (PST)
Received: from [24.199.45.54] (mcneil.com [24.199.45.54])
	by mail.mcneil.com (Postfix) with ESMTP id A2EEEF1865
	for <ports@freebsd.org>; Sun, 18 Feb 2007 13:52:43 -0800 (PST)
From: Sean McNeil <sean@mcneil.com>
To: ports@freebsd.org
Content-Type: text/plain
Date: Sun, 18 Feb 2007 13:52:43 -0800
Message-Id: <1171835563.87276.14.camel@triton.mcneil.com>
Mime-Version: 1.0
X-Mailer: Evolution 2.8.3 FreeBSD GNOME Team Port 
Content-Transfer-Encoding: 7bit
Cc: 
Subject: WITH_DEBUG too restrictive on CFLAGS?
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Feb 2007 22:11:12 -0000

I have found recently that the following ports will not compile on amd64
when WITH_DEBUG is set to "YES":

	converters/recode
	devel/pwlib

searching for all ports that set CFLAGS with -fPIC, I find:

	archivers/p7zip
	archivers/rpm4
	archivers/grzip
	audio/anthem
	audio/bmp-wma
	audio/liba52
	audio/libworkman
	audio/osalp
	audio/swhplugins
	audio/xmms-a52dec
	...

You get the idea - it is used pervasively.

The problem is, when WITH_DEBUG is YES, /usr/ports/Mk/bsd.port.mk will
strip out all flags from CFLAGS of the type -O* and -f*.  I don't think
this is a good idea.  First, the debugger can handle optimized code
pretty well and I can't build ports with debug introduced yet have ports
run optimized.  Second, -f* is a little over-aggressive when the one
flag that really must be removed is -fomit-frame-pointer.

Would it be possible to have this reviewed and, hopefully, changed to
allow -O and -f switches and just eliminate -fomit-frame-pointer?

Cheers,
Sean