From nobody Sat Jul  8 18:18:07 2023
X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qyz5q3MSlz4ltxN;
	Sat,  8 Jul 2023 18:18:07 +0000 (UTC)
	(envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "freefall.freebsd.org", Issuer "R3" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4Qyz5q2XBTz4LC8;
	Sat,  8 Jul 2023 18:18:07 +0000 (UTC)
	(envelope-from danfe@freebsd.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
	t=1688840287;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=7Dv/mELBWh/8W1+qRsimOopQkI3oLNZ7zFgG/+Aj9Fw=;
	b=m2LlnVj+wgnxf/Fu0qCS1cnHkK90JLAZREpMUPrLFGDBqa0RkKmaIvSndh6kIKROnUvKqz
	VKrRMSiOhpq91z3uPPwnc0PMkwWJzz5Ln4NdaroN+zFZ8jpkGxTLi1iUCgegJVHoBIuORQ
	cISsc9yii1TEcGx4yubULN0jGSF2ds9OPhuTUu3hgQCTk9tDckiHnbzyn9tl9NkRPxyTSa
	jk+0gZPLciimWgpq81h7Pc5+BZkRx/w+rBgdd2M1xNl7zXOPWYEzLkhLFyObEpZay8Rwld
	AlTMI0sIJ6ijFqW6LiWPJ21OFHaIuu/s7yIjGwuLSuPzreJvL46B22E6n/faHQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
	s=dkim; t=1688840287;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=7Dv/mELBWh/8W1+qRsimOopQkI3oLNZ7zFgG/+Aj9Fw=;
	b=GZ7tJBmuLn0ZGlhoWaO50fBU27bCPJIp5EilQfkn0G/3mOvzNxC9fqEFVX9JNBMp0ZvajY
	lW5VFCnGJkoj7j+Szsq2tN+wad3CSh2lkBgjJZnRw0DFte+pyFywAj8VjokRfoM82BcEbG
	RXEc6XNr5xrFlVrE2X7eghZT5m1Blp1I7lv/nAv5W2C6GYw/51f70+68Gk8SYqZJgsyH25
	qN6jQAQWNJM1kjeETc6EDvRovqMBzeLuNXI/Al6iPzQ3hrex7CS7X5zFsoLOQSx/KRe5KR
	7fHggr7MTq5miGnWQdleZMV9Csoz3p/xTzVaxhlevN/FyLpn7rqbT7w18X619w==
ARC-Authentication-Results: i=1;
	mx1.freebsd.org;
	none
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1688840287; a=rsa-sha256; cv=none;
	b=hnj4j9cjSTrmxp6rrhn+rAMpNe+ksE9ciVQBQ6hzGoFMowT7rNp7hqafknc3hn4ivgRvEO
	C4AOOB2fTERgV8EvepleXwTMzixI8IqrHqfQ5JsjaeAItouY72j8foIo77xZA8XCeqfmm3
	MPlBPtGPMm3jm8So9iwJCEJTM41crd7AEz0e2j/kqc+Ig9u/gYa6Viv3R8fezjVyNdIbDC
	k0NPUlY2mqYYfHXoRXqc6ySQTaAZ7SXh0J2sSKppvoK4J6WszsP+H0U2oNCnYZP8Fg0ss+
	AHIQbHKwXKHhDUzSZPei0qYy2ggXq51ucVS+uPXsnLghmGeD0BkAujqI4HH9Hw==
Received: by freefall.freebsd.org (Postfix, from userid 1033)
	id 406211330; Sat,  8 Jul 2023 18:18:07 +0000 (UTC)
Date: Sat, 8 Jul 2023 18:18:07 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Raphael Kubo da Costa <rakuco@freebsd.org>
Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,
	dev-commits-ports-main@freebsd.org
Subject: Re: git: ae8e32b08e33 - main - devel/qjson: Improve clang 16
 workaround for usage of the 'register' keyword
Message-ID: <ZKmoX_4Lz4_zC3Hn@FreeBSD.org>
References: <202307080950.3689opPW096575@gitrepo.freebsd.org>
List-Id: Commits to the main branch of the FreeBSD ports repository <dev-commits-ports-main.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main
List-Help: <mailto:dev-commits-ports-main+help@freebsd.org>
List-Post: <mailto:dev-commits-ports-main@freebsd.org>
List-Subscribe: <mailto:dev-commits-ports-main+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-ports-main+unsubscribe@freebsd.org>
Sender: owner-dev-commits-ports-main@freebsd.org
X-BeenThere: dev-commits-ports-main@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202307080950.3689opPW096575@gitrepo.freebsd.org>
X-ThisMailContainsUnwantedMimeParts: N

On Sat, Jul 08, 2023 at 09:50:51AM +0000, Raphael Kubo da Costa wrote:
> commit ae8e32b08e33bac7aec0f14f28e45d53dee6f565
> 
>   devel/qjson: Improve clang 16 workaround for usage of the 'register'
>   keyword
> 
>   Commit 3237ce1557467a3f89a3d1fa7a9308161665bf0c fixed the build on
>   CURRENT with a heavy hammer that made register a macro. This change
>   passes -Wno-register to the compiler instead, which is cleaner.

Correct fix is still like the following one-liner (untested):

    ${REINPLACE_CMD} -e 's,register ,,' ${WRKSRC}/src/json_scanner.cc

./danfe