From owner-freebsd-stable Wed Mar 6 11:11:24 2002 Delivered-To: freebsd-stable@freebsd.org Received: from mail.flipdog.com (sundog.flipdog.com [63.173.191.2]) by hub.freebsd.org (Postfix) with ESMTP id E42DA37B400 for ; Wed, 6 Mar 2002 11:11:16 -0800 (PST) Received: from aurora (localhost [127.0.0.1]) by mail.flipdog.com (Postfix) with ESMTP id 5FF92422D8; Wed, 6 Mar 2002 12:11:09 -0700 (MST) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 From: "Jan L. Peterson" To: Matthew Dillon Subject: Re: crashes on 4.5-RELEASE Cc: Ian Dowse , freebsd-stable@FreeBSD.ORG X-face: p=61=y<.Il$z+k*y~"j>%c[8R~8{j3WTnaSd-'RyC>t.Ub>AAm\zYA#5JF +W=G?EI+|EI);]=fs_MOfKN0n9`OlmB[1^0;L^64K5][nOb&gv/n}p@mm06|J|WNa asp7mMEw0w)e_6T~7v-\]yHKvI^1}[2k)] Dcc: References: <200202232021.aa04276@salmon.maths.tcd.ie> <20020304233509.5BFD0422D8@mail.flipdog.com> <200203050004.g25042F91389@apollo.backplane.com> In-reply-to: Your message of "Mon, 04 Mar 2002 16:04:02 PST." <200203050004.g25042F91389@apollo.backplane.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 06 Mar 2002 12:11:09 -0700 Message-Id: <20020306191109.5FF92422D8@mail.flipdog.com> Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG I have not had a crash since applying this patch: RCS file: /home/ncvs/src/sys/kern/uipc_socket.c,v retrieving revision 1.68.2.18 diff -u -r1.68.2.18 uipc_socket.c --- uipc_socket.c 13 Feb 2002 00:43:10 -0000 1.68.2.18 +++ uipc_socket.c 5 Mar 2002 00:02:59 -0000 @@ -525,7 +525,7 @@ if ((atomic && resid > so->so_snd.sb_hiwat) || clen > so->so_snd.sb_hiwat) snderr(EMSGSIZE); - if (space < resid + clen && uio && + if (space < resid + clen && (atomic || space < so->so_snd.sb_lowat || space < clen)) { if (so->so_state & SS_NBIO) snderr(EWOULDBLOCK); even with INVARIANTS turned off. Nor have I seen an xl0 watchdog timeout. I'm going to play with it a bit more before I call it good, but it's certainly looking better than before. I'll keep my debugging kernel in place, too, so that I can get a core dump and symbol table if I see another crash. I'll keep you all posted. -jan- -- Jan L. Peterson To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message