Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 06 Mar 2002 12:11:09 -0700
From:      "Jan L. Peterson" <jlp@softhome.net>
To:        Matthew Dillon <dillon@apollo.backplane.com>
Cc:        Ian Dowse <iedowse@maths.tcd.ie>, freebsd-stable@FreeBSD.ORG
Subject:   Re: crashes on 4.5-RELEASE 
Message-ID:  <20020306191109.5FF92422D8@mail.flipdog.com>
In-Reply-To: Your message of "Mon, 04 Mar 2002 16:04:02 PST." <200203050004.g25042F91389@apollo.backplane.com> 
References:  <200202232021.aa04276@salmon.maths.tcd.ie> <20020304233509.5BFD0422D8@mail.flipdog.com> <200203050004.g25042F91389@apollo.backplane.com>

next in thread | previous in thread | raw e-mail | index | archive | help
I have not had a crash since applying this patch:

RCS file: /home/ncvs/src/sys/kern/uipc_socket.c,v
retrieving revision 1.68.2.18
diff -u -r1.68.2.18 uipc_socket.c
--- uipc_socket.c	13 Feb 2002 00:43:10 -0000	1.68.2.18
+++ uipc_socket.c	5 Mar 2002 00:02:59 -0000
@@ -525,7 +525,7 @@
 		if ((atomic && resid > so->so_snd.sb_hiwat) ||
 		    clen > so->so_snd.sb_hiwat)
 			snderr(EMSGSIZE);
-		if (space < resid + clen && uio &&
+		if (space < resid + clen &&
 		    (atomic || space < so->so_snd.sb_lowat || space < clen)) {
 			if (so->so_state & SS_NBIO)
 				snderr(EWOULDBLOCK);

even with INVARIANTS turned off.  Nor have I seen an xl0 watchdog 
timeout.

I'm going to play with it a bit more before I call it good, but it's 
certainly looking better than before.

I'll keep my debugging kernel in place, too, so that I can get a core 
dump and symbol table if I see another crash.

I'll keep you all posted.

	-jan-
-- 
Jan L. Peterson
<jlp@softhome.net>



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020306191109.5FF92422D8>