Date: Thu, 9 Oct 2008 10:54:09 +0200 From: Marc Olzheim <marcolz@stack.nl> To: Ivan Voras <ivoras@freebsd.org> Cc: freebsd-hackers@freebsd.org Subject: Re: strftime's %c warning? Message-ID: <20081009085409.GA11669@zlo.nu> In-Reply-To: <gcj4lj$jr0$1@ger.gmane.org> References: <gcj4lj$jr0$1@ger.gmane.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--82I3+IH0IqGh5yIs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 08, 2008 at 10:20:00PM +0200, Ivan Voras wrote: > I'm trying to use the %c formatter in strftime(3), documented as: >=20 > " > %c is replaced by national representation of time and date. > " >=20 > ... which looks useful, except that in code in which WFORMAT is defined > as "1" I get this error: >=20 > str.c: In function 'ltime': > str.c:141: warning: '%c' yields only last 2 digits of year in some > locales on non-BSD systems > *** Error code 1 >=20 > Since the code I'm developing is definitely BSD-only (patch to pkg_* > infrastructure), should I: >=20 > a) stop using locale-based %c and choose my own date/time format > b) remove WFORMAT from the Makefile? >=20 > The same warning/error is generated by %x and %X, and %+ described in > the strftime man page isn't recognized. Yes. In FreeBSD 4.x, gcc was patched not to warn about these, so compiling with -Werror was possible even when using this. Since FreeBSD 5.x, this patch wasn't applied anymore. If you only want it to compile on your own system with -Werror, you can use this patch (and probably adapt it to %c, %x and %X as well): http://www.stack.nl/~marcolz/FreeBSD/gcc-strftime-format-freebsd7.patch.txt Marc --82I3+IH0IqGh5yIs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkjtxrEACgkQezjnobFOgrGY7wCfTsv6/EU4tbDV+u0R+n7FiXAI ML8An3PCMFn4cDGQcoPQ8hg4/BA8BwLU =b0Sp -----END PGP SIGNATURE----- --82I3+IH0IqGh5yIs--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081009085409.GA11669>