From owner-svn-src-all@FreeBSD.ORG Tue Oct 9 19:04:24 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8DEFBD3; Tue, 9 Oct 2012 19:04:24 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 3C09D8FC0C; Tue, 9 Oct 2012 19:04:24 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 89016B963; Tue, 9 Oct 2012 15:04:23 -0400 (EDT) From: John Baldwin To: src-committers@freebsd.org Subject: Re: svn commit: r241378 - in stable/8/sys/dev: cardbus pci Date: Tue, 9 Oct 2012 15:04:13 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p20; KDE/4.5.5; amd64; ; ) References: <201210091845.q99Ij88H054570@svn.freebsd.org> In-Reply-To: <201210091845.q99Ij88H054570@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201210091504.13804.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 09 Oct 2012 15:04:23 -0400 (EDT) Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, svn-src-stable-8@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2012 19:04:24 -0000 On Tuesday, October 09, 2012 2:45:08 pm John Baldwin wrote: > Author: jhb > Date: Tue Oct 9 18:45:08 2012 > New Revision: 241378 > URL: http://svn.freebsd.org/changeset/base/241378 > > Log: > MFC 201279,201280,201286,213907,214146,220195,222753,223371,225515,235833: > Various fixes to managing PCI BARs including proper support for managing > PCI ROM BARs: > - Teach the PCI bus driver to handle PCIR_BIOS BARs properly and remove > special handling for the PCIR_BIOS decoding enable bit from the cardbus > driver. The PCIR_BIOS BAR does include type bits like other BARs. > Instead, it is always a 32-bit non-prefetchable memory BAR where the low > bit is used as a flag to enable decoding. > - Explicitly track the state of all known BARs for each PCI device. The PCI > bus driver will now remember the size of a BAR obtained during the initial > bus scan and use that size when doing lazy resource allocation rather than > resizing the BAR. The bus driver will now also report unallocated BARs to > userland for display by 'pciconf -lb'. > - Add a constant for the offset of the ROM BIOS BAR in PCI-PCI bridges and > properly handle ROM BIOS BARs in PCI-PCI bridges. The PCI bus now also > properly handles the lack of a ROM BIOS BAR in a PCI-Cardbus bridge. > > Tested by: John Kozubik john kozubik com In particular this fixes problems with the cardbus driver not being able to read CIS information from cards that stored their CIS in a PCI ROM BAR. -- John Baldwin