From owner-cvs-all@FreeBSD.ORG  Mon Apr 23 11:40:20 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 916D516A407;
	Mon, 23 Apr 2007 11:40:20 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 64FCF13C45B;
	Mon, 23 Apr 2007 11:40:20 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id C152E4771F;
	Mon, 23 Apr 2007 07:40:19 -0400 (EDT)
Date: Mon, 23 Apr 2007 12:40:19 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: "Bruce M. Simpson" <bms@FreeBSD.org>
In-Reply-To: <462C8FFB.7030309@FreeBSD.org>
Message-ID: <20070423123711.I26224@fledge.watson.org>
References: <200704140101.l3E11kum000736@repoman.freebsd.org>
	<20070423095356.GB2742@FreeBSD.org> <462C8FFB.7030309@FreeBSD.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@FreeBSD.org, Gleb Smirnoff <glebius@FreeBSD.org>,
	cvs-all@FreeBSD.org, src-committers@FreeBSD.org
Subject: Re: cvs commit: src/sys/contrib/pf/net if_pfsync.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Apr 2007 11:40:20 -0000


On Mon, 23 Apr 2007, Bruce M. Simpson wrote:

> I agree with you that the current fix is not ideal, however it's the most 
> appropriate fix for the code as it currently stands.
>
> I stand by my work, you are free to improve upon it.

Part of the issue here is that kernel consumers aren't the only sources of 
multicast address registrations -- for example, user applications can register 
them directly using ioctls.  Kernel consumers should be given every 
opportunity to unregister addresses themselves (via event handlers on 
tear-down) before they are ripped out, but if they're still there when it 
comes time to free the interface, the stack should clean them up.

Robert N M Watson
Computer Laboratory
University of Cambridge