Date: Wed, 22 Dec 2004 12:33:08 +1030 From: Greg 'groggy' Lehey <grog@FreeBSD.org> To: Brian Fundakowski Feldman <green@FreeBSD.org> Cc: FreeBSD Architecture Mailing List <arch@FreeBSD.org> Subject: Re: Header files with enums instead of defines? Message-ID: <20041222020308.GX53357@wantadilla.lemis.com> In-Reply-To: <20041222014314.GB41996@green.homeunix.org> References: <20041222010143.GS53357@wantadilla.lemis.com> <20041222014314.GB41996@green.homeunix.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--uk6W7isEeLAaRh3S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tuesday, 21 December 2004 at 20:43:14 -0500, Brian Fundakowski Feldman wrote: > On Wed, Dec 22, 2004 at 11:31:43AM +1030, Greg 'groggy' Lehey wrote: >> Has anybody thought about replacing #defines with enums in header >> files? It would make debugging a whole lot easier. Foe example, I'm >> currently looking at a debug printout which contains: >> >> xerrno = 17, >> >> To find out what that means, I need to go to >> /usr/src/include/sys/errno.h and look for 17. I find: >> >> #define EEXIST 17 /* File exists */ >> >> If we were to change this to >> >> enum EEXIST = 17; /* File exists */ >> >> I'd then be able to see: >> >> xerrno = EEXIST, >> >> That makes debugging a whole lot easier. About the only down side I >> can see is that you can't #undef an enum. Is this a big deal? > > I think you'll screw up an awful lot of people that #ifdef based upon > the errno names. *sigh* Yes, I didn't think about that. Never mind. Greg -- See complete headers for address and phone numbers. --uk6W7isEeLAaRh3S Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFByNXcIubykFB6QiMRAnIPAJ0UoutKmbc9Z/swL1oUpI5PU7MomQCdF2eA itwxj7+9WLAfAycoXmfHPAU= =gw3y -----END PGP SIGNATURE----- --uk6W7isEeLAaRh3S--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041222020308.GX53357>