From owner-p4-projects@FreeBSD.ORG Tue Jun 22 14:22:03 2010 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id C28261065679; Tue, 22 Jun 2010 14:22:03 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 85C77106566B; Tue, 22 Jun 2010 14:22:03 +0000 (UTC) (envelope-from ivoras@gmail.com) Received: from mail-ww0-f54.google.com (mail-ww0-f54.google.com [74.125.82.54]) by mx1.freebsd.org (Postfix) with ESMTP id 85C3E8FC23; Tue, 22 Jun 2010 14:22:02 +0000 (UTC) Received: by wwe15 with SMTP id 15so1280087wwe.13 for ; Tue, 22 Jun 2010 07:21:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:sender:received :in-reply-to:references:from:date:x-google-sender-auth:message-id :subject:to:cc:content-type:content-transfer-encoding; bh=8fYE9qBNPF5/FdkZzX2eqhagfQLXBEp7r2dsNzlDxvI=; b=BbgulzKdGMjojfl5hvDzNmqE5PG43I7zF/iGZG9zNBIF0zBINcVro02LzqP3i809G0 ek+yzDkfsBKZ3BFVcKejIFTNMuL3NQUfZ6Q/sYvFuY1Uv+ZAvO3Pz/3vzI9MeGX8Piz/ eW7x3CurMydTqWRtNXSvucqjmWldSdWebWzSo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=MuNxZ6afwWmpSxuz9U4KkiJwmrnB6qamrCy1NQfOX7tAAeU6yba59SkQh7HvfVGg1u bh0GNDL/9V+1xhNz1Z40YccxXac7psABv/L8PfziXYkui8nCsp84CDRAkFHtaBsF6OKC Gr1/4MY0gzReMS8Fpg3Lv7oA/Hu9XpW1fqPk4= Received: by 10.227.68.134 with SMTP id v6mr6143844wbi.110.1277216517585; Tue, 22 Jun 2010 07:21:57 -0700 (PDT) MIME-Version: 1.0 Sender: ivoras@gmail.com Received: by 10.216.89.197 with HTTP; Tue, 22 Jun 2010 07:21:36 -0700 (PDT) In-Reply-To: References: <201006210045.o5L0jgZ3009138@repoman.freebsd.org> From: Ivan Voras Date: Tue, 22 Jun 2010 16:21:36 +0200 X-Google-Sender-Auth: l6gTh23w354H5qSRpT_q5G846zI Message-ID: To: Garrett Cooper Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Andrew Pantyukhin , Perforce Change Reviews , Julien LAFFAYE Subject: Re: PERFORCE change 180026 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jun 2010 14:22:04 -0000 On 21 June 2010 03:25, Garrett Cooper wrote: > On Sun, Jun 20, 2010 at 6:15 PM, Ivan Voras wrote: >> On 21 June 2010 02:58, Julien LAFFAYE wrote: >>> Why don't you use read_plist(Package *pkg, int fd) from libpkg instead? >> >> Should I, in the light of >> YES_I_KNOW_THE_API_IS_RUBBISH_AND_IS_DOOMED_TO_CHANGE ? I thought the >> entire lib is to be rightfully scrapped and implemented as something >> decent. > > =C2=A0 =C2=A0Yes, it will be eventually, but there's no real harm in > implementing this bit with read_plist for the time being though. If > and when dforsyth's work gets straightened out, a lot of this crud > will get scrapped and/or properly rewritten. Just to confirm this: for example, if I need to get the MD5 hash of a file from this structure, is the accepted practice to scan through the entire list searching for the file node and then scan the rest of the list searching for the first comment node that begins with "MD5:"?