From owner-svn-ports-head@FreeBSD.ORG  Mon Jun 24 12:19:28 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 85262F5E;
 Mon, 24 Jun 2013 12:19:28 +0000 (UTC) (envelope-from zi@FreeBSD.org)
Received: from exodus.zi0r.com (exodus.zi0r.com [71.245.171.203])
 by mx1.freebsd.org (Postfix) with ESMTP id 5BBC81349;
 Mon, 24 Jun 2013 12:19:27 +0000 (UTC)
Received: from exodus.zi0r.com (localhost [127.0.0.1])
 by exodus.zi0r.com (Postfix) with ESMTP id DF80D3A097;
 Mon, 24 Jun 2013 08:19:20 -0400 (EDT)
X-Virus-Scanned: amavisd-new at zi0r.com
Received: from exodus.zi0r.com ([127.0.0.1])
 by exodus.zi0r.com (exodus.zi0r.com [127.0.0.1]) (amavisd-new, port 10026)
 with LMTP id RwsA3JMEp9Bp; Mon, 24 Jun 2013 08:19:19 -0400 (EDT)
Received: from exodus.zi0r.com (syn.zi0r.com [71.245.171.202])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by exodus.zi0r.com (Postfix) with ESMTPSA id 7A0A03A094;
 Mon, 24 Jun 2013 08:19:19 -0400 (EDT)
Date: Mon, 24 Jun 2013 08:19:18 -0400
From: Ryan Steinmetz <zi@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Subject: Re: svn commit: r321677 - in head/security/duo: . files
Message-ID: <20130624121917.GA85793@exodus.zi0r.com>
References: <201306241155.r5OBtgQj057667@svn.freebsd.org>
 <20130624120316.GB79369@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20130624120316.GB79369@FreeBSD.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Jun 2013 12:19:28 -0000


On (06/24/13 12:03), Alexey Dokuchaev wrote:
>On Mon, Jun 24, 2013 at 11:55:42AM +0000, Ryan Steinmetz wrote:
>> New Revision: 321677
>> URL: http://svnweb.freebsd.org/changeset/ports/321677
>>
>> +.if ${OSVERSION} >= 1000000
>> +USE_GCC=	yes
>> +.endif
>
>Presuming it's due to Clang...
>

Correct.

>Two quick questions: 1) why not just say USE_GCC=any; and 2) how hard would
>it be to fix Clang fallouts, and remove any explicit compiler requirement?
>

I was not aware that USE_GCC=any would do this.  However, I'm going to
leave the port as-is for now, simply to avoid repo churn.  I expect the
clang fixes to make it into the next release shortly, and the workaround
will be removed at that time.

The proposed changes were submitted by brooks@ upstream for
review/inclusion in the next release of duo.

>Note that =yes implies GCC 4.6+ or something, yet on OSVERSION < 1000000
>apparently our default system 4.2 is enough.
>
>>  	@${CAT} ${PKGMESSAGE}
>
>It would be nice if cat(1) had been surrounded with ${ECHO_MSG}'s to ensure
>consistent padding when installing from package vs. ports.  If any padding
>is present in the pkg-message file itself, it should be removed.

This might be a good idea for inclusion in bsd.port.mk.  I believe that
the current 'norm' is to simply cat pkg-message.

>
>./danfe

-- 
Ryan Steinmetz
PGP: EF36 D45A 5CA9 28B1 A550  18CD A43C D111 7AD7 FAF2